* Attempt to properly detect gettext [1]
* Add support for @<pre|post>[un]exec plist directives [2]
* Add support for the new @sample plist directive changes [2]
* Modify the text when checking for used OPTIONS [3]
PR: 204370 [1]
204900 [2]
204575 [3]
${PERL5} points to a specific version of perl, say, perl5.22.1, it is
fine to use it in a ports Makefile to do Perly things, but ports using
it must use ${PERL}, that points to /usr/local/bin/perl so that if the
minor version is updated, the shebang keep working.
While there, make some ports use shebangfix, regen a few patches, and
bump PORTREVISION where a shebang went from PERL5 to PERL.
PR: 205367
With hat: portmgr
Sponsored by: Absolight
* Add support for @(...) notation [1]
* Remove the check for USES being sorted. Order is important. [2]
* Add support for making sure @owner and @group are properly reset [3]
PR: 202570 [1]
203908 [2]
202711 [3]
* Only report "make makepatch" once per patch file [1]
* Attempt to re-word the make makepatch warning to avoid unnecessary repo
churn [2]
* Attempt to test some other macros for sorting [3]
* Do not check empty dependencies for validity [4]
PR: 202050 [1]
201647 [2]
201409 [3]
202052 [4]
Submitted by: gerald [1]
* Add a check for BROKEN similar to IGNORE [1]
* Quiet the noise when used with Perl 5.22 [2]
* Fix a bug checking for USES sortedness [3]
* Correct a logic bug checking for USE_ANT [4]
PR: 200634 [2]
200792 [3]
200421 [4]
Submitted by: pi [2]
John Hein <z7dr6ut7gs@snkmail.com> [4]
Reported by: koobs [1]
* Correct a typo. This should have been SITE_ARCH_REL. [1]
* Pre-populate USES with an explicit grep of the Makefile. [2]
* Correct a typo to prevent direct command usage checking in pkg-* files. [3]
* Adjust the order of first-paragraph items so that proper checking is done. [4]
* Adjust the warning about installing docs by wrapping with
.if ${PORT_OPTIONS:MDOCS}. [5]
* Add a check for ${SETENV} instead of ${ENV}. [5]
PR: 199974 [2]
199693 [3]
199428 [4]
199417 [5]
Submitted by: adamw [4]
sunpoet [1]
* Check the patches to make sure they were generated using ``make patch'' [1]
* Do not throw a bunch of Perl errors if the makefile is bad [2]
PR: 197747
198887
* Exclude .git directories from error reporting [1]
* Add some additional Perl checks for STAGEDIR [2]
* Try not to flag on direct use of "install" if we're running a make command [3]
* Fix the checks for Perl given the new hierarchy [4]
PR: 195780 [1]
194759 [3]
196222 [4]
Submitted by: gerald [3]
Yasuhiro KIMURA <yasu@utahime.org> [1]
Requested by: mat [2]
Portlint's history goes back to itojun. I've researched his open source
projects and he either used two licenses:
BSD3CLAUSE: magicpoint, sch
His own license: portlint, snooper, various camera tools, etc
Debian asked him years ago about his license to see if it complies with
thier DFSG:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=88416
Example of his license:
Copyright(c) 1997 by Jun-ichiro Hagino <itojun@itojun.org>.
All rights reserved.
Freely redistributable. Absolutely no warranty.
OR
Absolutely no warranty. Pray before try. Freely redistributable.
Hope I'm not crossing any boundaries here, but in my effort to clean up
"BSD" licenses in the ports tree this one certainly is not and sadly we
can't just ask him.
Before, we had:
site_perl : lib/perl5/site_perl/5.18
site_perl/perl_arch : lib/perl5/site_perl/5.18/mach
perl_man3 : lib/perl5/5.18/man/man3
Now we have:
site_perl : lib/perl5/site_perl
site_arch : lib/perl5/site_perl/mach/5.18
perl_man3 : lib/perl5/site_perl/man/man3
Modules without any .so will be installed at the same place regardless of the
Perl version, minimizing the upgrade when the major Perl version is changed.
It uses a version dependent directory for modules with compiled bits.
As PERL_ARCH is no longer needed in plists, it has been removed from
PLIST_SUB.
The USE_PERL5=fixpacklist keyword is removed, the .packlist file is now
always removed, as is perllocal.pod.
The old site_perl and site_perl/arch directories have been kept in the
default Perl @INC for all Perl ports, and will be phased out as these old
Perl versions expire.
PR: 194969
Differential Revision: https://reviews.freebsd.org/D1019
Exp-run by: antoine
Reviewed by: perl@
Approved by: portmgr
* Remove @MASTERSITES_WHITELIST
* Remove some remnants of multi-OS support: always false conditions and
unused variables ($automan, $autoinfo, $manstrict, $mancompress,
$multiplist, $newxdef, $rcsidinplist, $ldconfigwithtrue)
* Remove check for USE_SIZE
* Remove check for 'Version Required' in header
* Remove pkgtools remnants: fix pkg_version invocations,
remove check for PKGINSTALLVER, remove check for old packages in $portsdir
* Update check for IGNOREFILES macro
* Remove comment about EXEC_DEPENDS
* Remove check for NO_CONFIGURE/NO_PATCH
* Remove '@dirrm for %%DOCSDIR%%' check
* Remove pkg-comment check
* Remove check for /usr/X11R6
* Remove check for gcc_val 3.x and 4.1 conditions
* STAGE is now required
* Remove MANLANG check
* Add NOPORTEXAMPLES/NOPORTDOCS deprecation warning
* Add @stopdaemon, @cwd deprecation warning
* Add PLIST_DIRSTRY deprecation warning
* Add check for make :L :U modifiers
* Add check for for MAN[1-9] macro
* Allow use of absolute path in plist
* Fix checks for EXTRACT_SUFX
* Fix USE_ANT and USES=gmake warning
* Convert WITH(OUT)_$1 to PORT_OPTIONS:M$1 in warning
* Convert USE_DOS2UNIX to USES=dos2unix in warning
* Convert USE_ZIP to USES=zip in EXTRACT_SUFX check
* Convert USE_PERL5 to USES=perl5 in warning
* Convert USE_ICONV to USES=iconv in warning
* Modify checkplist() to accept @fc/@shell/other new keywords
PR: 194285
Submitted by: ak
* Do not report on DEBUG as an OPTION. [1]
* Check for use of muted INSTALL_foo commands.
* Warn on use of @dirrm[try].
* Check to make sure rc.d scripts contain a '# PROVIDE:' line. [2]
* Check to see that the options provided to USES are sorted. [3]
* Fix an errant "direct use of command" warning. [4]
* Remove the check to see if StartupNotify is the empty string in
DESKTOP_ENTRIES. This is allowed per the spec and per the porter's
handbook. [5]
* Check for empty lines in plist. [6]
* Check for direct command use in SHEBANG_FILES. [7]
PR: 192525 [1]
193464 [2]
193792 [3]
193793 [4]
193456 [5]
193794 [6]
193795 [7]
* Make sure a port is placed in its proper category directory. [1]
* Don't check INSTALL_TARGET for direct command use. [2]
* Remove the single MASTER_SITE warning. [3]
* Check to make sure patch file names contain no more than 100 characters. [4]
PR: 191631 [2]
191079 [3]
Submitted by: wen heping <wenheping@gmail.com> [1]
gerald [2]
Requested by: demon [4]
Discussed on: ports@ [3]
* Add s3.amazonaws.com to the list of whitelist master sites. [1]
* Correct a typo. [2]
* Add support for the @sample directive. [3]
* Check for USE_AUTOTOOLS=libtool and suggest USES=libtool instead.
PR: 183864 [3]
Submitted by: skreuzer [1]
culot [2]
* Remove www.freebsd.org/~$user check from urlcheck()
* Remove 'in the module alias name' warning
* Remove 'binary -ko'
* Silence warnings in case if svn binary does not exist (try 2)
* Use more strict regexp for share/doc detection
* Add sdl-config to direct commands check
* Fix phase 2 of direct use of pathnames check
* Ignore comments in direct use of pathnames check
* Support nested knobs in plist for OPTIONS_SUB check
* Add check for @dirrm(try) libdata/pkgconfig in plist
* Remove USE_MESA, INSTALLS_SHLIB, APACHE_COMPAT, USE_XPM from deprecated
macro check
* Fix 'Consider adding support for a NLS knob to conditionally disable gettext'
warning in the case of use 'NLS_USES= gettext'
PR: 188389
Submitted by: ak
- Remove NetBSD support, its completely bitrotted
- Suggest to set DEVELOPER=yes in /etc/make.conf if committer flag specified in command line
- Fix WARN: Makefile: [11]: possible direct use of command "libtool" found...
- Small fixes:
* 'WWW: UR:' -> 'WWW: URL'
* @option_helpers -> remove leading '_' use _$m instead
* fix a few 'undefined variable' warnings
- Make MAN{X} checks NO_STAGE only (consolidate/simplify check)
- Make some checks in checkplist NO_STAGE only
- Convert PERL_CONFIGURE check to USE_PERL5=configure
- Make "use .if ${PORT_OPTIONS:MDOCS} to wrap installation of files into
$localbase/share/doc" warning NO_STAGE only
- Add special case for global options(DOCS/EXAMPLES/NLS/IPV6) in
OPTIONS_DEFINE, but not in PORT_OPTIONS:M$i
- Check for relative path (/../) in *DEPENDS
- Remove MASTER_SITES that don't resolve or returns 5xx
- Remove LINTSKIP check that was commented since 1997
PR: 186639
Submitted by: ak
* Check for old-style LIB_DEPENDS
* Don't emit a warning if there is only one MASTER_SITE, but that MASTER_SITE
is known in our list of site macros. [1]
* Attempt to find corrupt DESKTOP_ENTRIES that do not specify a proper
startupnotify value. [1]
Reported by: Hardy Schumacher <hardy.schumacher@gmx.de>
* Correct some unitialized problems that pop up with certain ports
* Replace USE_DOS2UNIX with USES=dos2unix
* Do not check for direct use of commands in OPTIONS descriptions
Reported by: Hardy Schumacher <hardy.schumacher@gmx.de>
* Do not warn on direct use of "false" if it is found in DESKTOP_ENTRIES. [1]
* Make sure the DESKTOP_ENTRIES true/false parameter does not include quotes.
* Remove an unreferenced variable dereference. [2]
* Add some additional variables to avoid explicit command use checks. [3]
PR: 185086 [1]
185225 [2]
185110 [3]
* Fix a typo resulting in an undefined function [1]
* Add X11 to the list of common OPTIONS [2]
* Remove an errant space [2]
* Do not warn on empty .svn directories. [2]
PR: 183330 [1]
Submitted by: Kubilay Kocak <koobs.freebsd@gmail.com> [1]
Reported by: eadler [2]
* Mute svn warnings if .svn doesn't exist. [1]
* Add check for ${OPTION}_* (option helpers) [1]
* Suggest LICENSE as warning [1]
* Fix get_makevar and use instead of direct calls to make(1) [1]
* Remove MAKE_JOBS_SAFE [1]
* Remove vestiages of old OPTIONS [1]
* Suggest converting to stage if NO_STAGE is defined. [1]
* Check for use of MANCOMPRESSED when STAGE support is enabled.
* Do not warn about man pages in the plist if the port is built with stage
support.
* Do not flag .svn in the search for dotfiles.
Submitted by: ak [1]
Changes:
* Fix recommending to replace USES=gmake with ${GMAKE} [1]
* Ignore USES when recommending to replace direct commands [1]
* Fix COMMENT check so it checks for length even if it
is not formatted properly [2]
PR: ports/181359 [1]
Submitted by: Alan Hicks <ahicks@p-o.co.uk> [1]
Reported by: many
PR: ports/181730 [2]
Submitted by: gerald
Approved by: maintainer timeout (> 1 month)
* Fix some minor issues in the portlint man page [1]
* Warn about using ${SITE_PERL} in depends [2]
* Add a check to see that OPTIONS_{RADIO/SINGLE/MULTI/GROUP}_SOMETHING exists
if OPTIONS_{RADIO/SINGLE/MULTI/GROUP} is defined [3]
* Join all lines with a backslash before doing anything to fix parsing
of comments [4]
* Stop looping through MASTER_SITES as soon as a comment is seen [4]
* Detect plain ftp/http sites and print a warning if none have been
found [4]
* Opt for USES=pkgconfig instead of USE_PKGCONFIG [5]
* Add check for ${TRUE}/${FALSE} in DESKTOP_ENTRIES [5]
* Remove CDRTOOLS check [5]
* Remove USE_REINPLACE check [5]
* Remove USE_GETOPT_LONG check [5]
* Modify USE_GETTEXT -> USES gettext [5]
* Remove WITHOUT_NLS check [5]
* Relax headers check for $FreeBSD$ + $MCom$ case [5]
* Fix URL suggestion for CPAN so that it ends with a '/' [6]
PR: 178952 [2]
179262 [3]
179338 [5]
180260 [6]
Submitted by: eadler [1]
"Anton Yuzhaninov" <ayuzhaninov@openstat.ru> [2]
"Ilya A. Arkhipov" <rum1cro@yandex.ru> [3]
tijl [4]
Alex Kozlov <spam@rm-rf.kiev.ua> [5]
Anes Mukhametov <anes@anes.su> [6]
* Add support for the PL_SVN_IGNORE environment variable. [1]
* Promote PORT_OPTIONS:MDOCS to NOPORTDOCS. [2]
* Add a check for pure FTP or HTTP mirrors in MASTER_SITES. [3]
PR: 177043 [1]
177048 [2]
177805 [3]
Submitted by: tota [1]
pclin [2]
Tijl Coosemans <tijl@coosemans.org> [3]
* Add a missing comma to fix a really weird error on checking certain ports. [1]
* Remove unused PL_CVS_IGNORE [2]
* Add check for a single space after WWW: in pkg-descr [2]
* Clarify 'Created by:' warning message [2]
* Add new OPTIONS_* knobs to @options_early [2]
* Add supported for USE_GCC=yes. [3]
PR: 175186 [1]
175317 [2]
174758 [3]
Submitted by: gerald [1] [3]
ak [2]
- Pet portlint in porttools
* Use PORT_OPTIONS:MDOCS instead of NOPORTDOCS
* Replace tab with space WWW: line in pkg-descr
PR: ports/174860
Submitted by: tota (myself)
Approved by: maintainers (timeout > 2 months)
* Add a test for empty(${VARIABLE}) (instead of empty(VARIABLE)) [1]
* Add a test for NOPORTDOCS and point to PORT_OPTIONS:MDOCS [1]
* Add GitHub to the MASTERSITES whitelist (as this is a cloud service). [2]
* Add a warning about .DS_Store files appearing in the port directory. [3]
* Add a check for the new style Makefile headers. [4]
* Remove the CVS checks now that the ports tree has been converted to SVN.
Note: we need SVN checks. [5]
* Add support for optionsNG [6]
* Deprecate USE_GNOME=pkgconfig [6]
* Add missing period at the end of some sentences [6]
PR: 172621 [1]
172834 [2]
173649 [3]
174688 [4]
174693 [5]
174697 [6]
Submitted by: Alan Hicks <ahicks@p-o.co.uk> [1]
"Steven Kreuzer" <skreuzer@exit2shell.com> [2]
ehaupt [3]
crees [4]
tota [5]
Alex Kozlov <spam@rm-rf.kiev.ua> [6]
* Reduce false alarms when checking for MAN* and MAN*PREFIX. [1]
* Don't over-warn when using PORT_OPTIONS:MDOCS with
${PREFIX}/share/doc/${PORTNAME}. [2]
* Remove spurious warnings about CPPFLAGS and LDFLAGS. [3]
* Make sure we do not throw a warning if USE_GCC=any is used. [4]
PR: 169745 [1]
171535 [2]
172335 [3]
Submitted by: sunpoet [1]
Hung-te Liang <lhd@cs.nctu.edu.tw> [2]
glarkin [3]
Suggested by: eadler [4]
* Add a check for over-specific shared lib dependencies [1]
* Add support for TEST_DEPENDS [2]
* Make the error for NO_CHECKSUM to be scarier [3]
PR: 165851 [1]
166173 [2]
167923 [3]
Submitted by: matthew [1]
sunpoet [2]
"Bryan Drewery" <bryan@shatow.net> [3]
* Include LICENSE_FILE and LICENSE_GROUPS in the regexp check. [1]
* Add LICENSE_DISTFILES. [1]
* Add a check for the reassignment of ECHO_MSG [2]
* Remove old X.Org checks [3]
* Add PROJECTHOST to the PORTNAME section [4]
Reminded by: Jan Beich <jbeich@tormail.net> [1]
Requested by: jgh [2]
Submitted by: eadler [3]
Alex Kozlov <spam@rm-rf.kiev.ua> [3]
* Complete the check for CPPFLAGS being set indirectly by checking MAKE_ENV
in addition to CONFIGURE_ENV. [1]
* Remove checks for port file headers as we are phasing them out in FreeBSD. [2]
* Check to make sure CPAN URLs end with a '/'. [3]
* Check for LDFLAGS being overridden just as we do for CPPFLAGS [4]
* Suggest += instead of = to override CPPFLAGS and LDFLAGS [4]
* Check for any overriding use of *FLAGS and suggest an alternative [4]
* Do not warn of direct command use for WX_COMPS. [5]
* Add support for named license macros when checking for order. [6]
* Make the check for the direct Apache dependency more strict. [7]
PR: 160448 [1]
159272 [3]
160959 [4]
161971 [5]
163617 [6]
163523 [7]
Submitted by: gjb [2]
amdmi3 [4]
* Change a comment to relfect the check number [1]
* Add a check to see if a file that ends in ".core" was checked into CVS [2]
* Do a proper check for 2 or 3 tuple depends [3]
* Correct the detection of the WWW string in pkg-descr [4]
PR: 159057 [3]
159522 [4]
Reported by: Ilya A. Arkhipov <micro@heavennet.ru> [1]
Requested by: netchild [2]
Sbumitted by: sunpoet [4]
* Be more careful is searching for WITH(OUT)_FOO OPTIONS checks so to avoid
false positive warnings. [1]
* Support := in the *_DEPENDS section. [2]
* Make sure we expand DISTNAME to catch potential superfluous uses of it. [3]
* Fix the error seen when one passes CPPFLAGS to CONFIGURE_ENV. [4]
* Add the license block check after the MAINTAINER block [5]
* Add a check for use of ${FIND}...${XARGS} ${RM}. [6]
PR: 156164 [1]
155753 [2]
154320 [3]
158305 [5]
157566 [6]
Submitted by: sahil [1]
"Ilya A. Arkhipov" <micro@heavennet.ru> [5]
Reported by: pav [4]
* Check for the direct assignment of BUILD_DEPENDS to RUN_DEPENDS [1]
* Add a deprecated pointer for USE_XPM. [2]
* CPPFLAGS is now passed to CONFIGURE_ENV automatically. [3]
PR: 154896 [1]
155550 [3]
Submitted by: eadler [2]
* Check for duplicate MANx macros [1]
* Add a warning if the wrong CPAN URL is used for the WWW URL [2]
* Remove an obsolete CPAN warning [3]
PR: 154069 [1]
154149 [2]
154724 [3]
Submitted by: skreuzer [2]
milki@rescomp.berkeley.edu [3]
