* Remove check for SIZE and MD5 in distinfo since this was a rush job, and
missed some common cases. [1]
* Re-enable use strict, and fix portlint to obey it
Requested by: eik [1]
* Add a generic check for deprecated macros (e.g. the recent autotools batch),
and add USE_MESA to the set [1]
* Only use USE_LIBTOOL_VER for checking .la file installation [1]
* Add a check for USE_LIBLTDL and warn about directly using a libltdl
dependency [1]
* Check distinfo to make sure each file in DISTFILES has SIZE and MD5 entries
if NO_SIZE and NO_CHECKSUM are not defined
Submitted by: krion and tobez [1]
* Do not complain about SIZE if NO_SIZE is set [1]
* Allow ``%%PORTDOCS%%@unexec rmdir %D/%%DOCSDIR%% 2>/dev/null || true'' in
pkg-plist when using PORTDOCS
* Be a little smarter about complaining when .la files are seen in the plist.
Also, point users to the GNOME site for elimintating .la files altogether [2]
* Super-scrub PKGNAME and PORTVERSION for illegal characters [3]
* Check for port versions that go backwards [3]
PR: 66891 [2]
Submitted by: krion [1]
leeym [2] (based on)
eik [3]
* Add a check to see if PLIST_{FILES,DIRS} is defined and pkg-plist exists.
If so, print an error [1]
* Add a check for direct usage of iconv.\d+ and intl.\d+ instead of USE_ICONV
and USE_GETTEXT [1]
* If %%DOCSDIR%% is used in the plist, make sure @dirrm %%DOCSDIR%% is also
present [1]
* Don't flag a missing distinfo as FATAL [2]
Submitted by: krion [1]
eik [2]
* Add some additional checks for USE_* variables included too late [1]
* Add a check for SIZE in distinfo [2]
* Fix a small style nit [2]
* Warn is USE_SIZE is used in a port's Makefile
* Check to see if a port supports WITHOUT_NLS if USE_GETTEXT is defined [3]
Submitted by: eik [1]
krion [2]
Requested by: kris [3]
* Add code for formal master/slave checking rules as defined in ports/64393 [1]:
1. A port is a slave port if and only if MASTERDIR != .CURDIR
2. Slave ports should define MASTERDIR using one of the following lines:
MASTERDIR= ${.CURDIR}/../../<category>/<port>
MASTERDIR= ${.CURDIR}/../<port>
3. Non-slave ports shouldn't define MASTERDIR at all
4. The last line of a slave port's Makefile has to be
.include "${MASTERDIR}/Makefile"
5. The last line of a non-slave ports Makefile must be one of:
.include <bsd.port.mk>
.include <bsd.port.post.mk>
6. slave ports may not include bsd.port(.pre).mk
* Check to make sure MACHINE_ARCH is not defined and make sure it is never
tested directly [2]
* Fix some grammar nits [3]
PR: 64420 [1]
Submitted by: eik [1]
krion [3]
Requested by: kris [2]
* Add dirname and egrep direct command use checks
* Add a missing '?' in checking for text after bsd.port(.post)?.mk [1]
* Add a check to make sure OPTIONS is set before bsd.port.pre.mk
Submitted by: eik [1]
* Fix some grammar nits in portlint.1
* Add some missing options to the summary in portlint.1
* Reorganize some option descriptions in portlint.1
* Add an ENVIRONMENT section describing PL_CVS_IGNORE and PORTSDIR in
portlint.1
* Don't check the MAINTAINER field for direct command use [1]
* Add a new PL_CVS_IGNORE environment variable that allows users to filter
out certain patterns from the CVS files check [2]
* Only warn about CATEGORY problems if the user is in PORTSDIR [3]
* Sync new command macros with recent bsd.port.mk changes
* Correct a regular expression problem when looking for direct command use [4]
PR: 61562 [1]
61449 [2] [3]
Submitted by: Sergey Matveychuk <sem@ciam.ru> [1]
sergei [3]
leeym [4]
* Check to make sure RCS tags begin with capital letters [1]
* Do not look direct command use in .for loops [2]
PR: 60947 [1]
Submitted by: leeym [1]
petef [2]
* Fix up the usage text
* Ignore arguments passed to REINPLACE_CMD so portlint will not complain on
things such as ${REINPLACE_CMD} -e 's,/usr/local,${PREFIX},g' [1]
* Only match libraries installed into lib when looking for .so's [2]
* Try to make the PKGCATEGORY check a little more forgiving to committers
checking single ports [3]
PR: 60608 [1]
60803 [2]
Submitted by: leeym [1] [2] (based on)
dougb [3]
* Correct a typo (-n should be -N) [1]
* Don't check comments for direct command use [2]
Submitted by: pav [1]
Sascha Holzleiter <sascha@root-login.org> [2]
* Check to make sure new ports do not contain PORTEPOCH
* Throw a FATAL error if an additional file exists in the port directory but
not in CVS [2]
* Throw a FATAL error if a file is in CVS but not in the port's directory [2]
* Throw a FATAL error if a file was deleted from CVS but still in the port's
directory [2]
* Warn if a new file contains a non-empty RCS Id [2]
* Add a missing ``if ($verbose)'' [2]
Submitted by: arved [1]
eik [2]
* Add some linenumbers to the whole file search
* Hack the direct command use code some more
* Add a check for the deprecated USE_MESA
* Allow PKGCATEGORY not in CATEGORIES [1]
* Allow %B in pkg-plist, as it has a valid prefix [1]
* Allow simple rm -f, it needs no redirection [1]
* Add portlintgrep.pl, an example on how to use portlint to find certain
portlint problems in the ports tree [2]
Submitted by: dinoex [1]
eik [2]
* Add a check to make sure the last line of a slave port's Makefile contains
an appropriate MASTERDIR include directive [1]
* study() the $whole string to improve performance [1]
* Fix the search for direct command use
* Check for ports that may break INDEX [1]
* Check for GNOME ports that use pre-patch and gnomehack
Submitted by: eik [1]
* Check for variables that are used too late [1]
* Rename some of the language variables. Admittedly, this needs more work.
* Check for anything after bsd.port(.post).mk [1]
* Fix the language category search code
* Bump version to 2.4.7
Submitted by: Oliver Eikemeier <eikemeier@fillmore-labs.com> [1]
rest of the world.
* Fix the -V option in the manpage [1]
* Handle the case where parentheses may not exist around NOPORTDOCS [2]
* Bump version to 2.4.6
Submitted by: mat [1]
Reported by: kris [2]
* Check for the common typo, NOPORTSDOC [2]
* Make sure .CURDIR is the primary category [3]
* Check for USE_* macros that are user-settable [4]
* Try to be a little more intelligent when checking for macros that need to
appear earlier
* Ignore make directives when checking for extra items in certain sections
PR: 55921 [1]
57751 [2]
58292 [3]
58525 [4]
Submitted by: edwin [1]
Oliver Eikemeier <eikemeier@fillmore-labs.com> [2] [3] [4]
* Add support for the Polish locale
* Try to add more intelligence to the direct command use code
* Fix up the wording about numbered info files [1]
Suggested by: gerald [1]
* Clean up some more Perl warnings
* Make sure all the MAN macros are printed in all uppercase
* Add perl, ruby, python, and the auto* tools to the list of direct
commands [1]
PR: 55529 [1]
Submitted by: Jens Rehsack <rehsack@liwing.de> [1]
* Document the -V option [1]
* Properly suggest ${STRIP_CMD} (not ${STRIP}) instead of strip [2]
* Correct the version string
PR: 54993 [1]
Submitted by: Mark Linimon <linimon@lonesome.com> [1]
gerald [2]
Pointy hat to: me [2] (I should have used Gerald's patch as-is)
* Document the -A option in the usage
* Add my name to the list of AUTHORS
* Clean up some warnings produced by perl -cwT
* Check for the existence of pkg-comment and flag it as FATAL [1]
* Add OMF checking support similar to the info checking code
* Add support for {DOCS,EXAMPLES}DIR macros [2]
* Don't check commented out URLs in MASTER_SITES [3]
* Add file, find, strip, and xargs to the list of direct command names [4]
* Don't search for command names in COMMENT [5]
* Add SITE_PERL support [6]
* Add DISTFILE/MASTER_SITE grouping support [7]
* Check to make sure the MAINTAINER field contains a valid email address
* Add support for {EXTRACT,PATCH}_DEPENDS
* Add USE_GETOPT_LONG support [8]
PR: 48199 [1]
53371 [2]
43537 [3]
54381 [6]
39487, 44099, 48221 [7]
54497 [8]
Submitted by: Sergei Kolobov <sergei@kolobov.com> [2] [8]
gerald [4] (file and strip)
Oliver Eikemeier <eikemeier@fillmore-labs.com> [6]
Reported by: kris and nork [5]
- don't give a warning to use binary mode because of a possible RCS tag
if the tag is $FreeBSD$.
- bump PORTREVISION
Approved by: maintainer timeout, portmgr (kris)
the version to 2.3.2.
- Add checks for empty files, empty directories, core files, more
possible backup files, dotfiles, symlinks and CVS directories.
- Do not assume PATCHDIR always includes "/files/". Use the best
method to check whether a file is added to @checker as a patch file.
- Some trivial message style fixes.
- Conform to the new port layout, finally.
- Use COMMENT, DESCR, PLIST, PKGINSTALL, PKGDEINSTALL, PKGREQ,
PKGMESSAGE, SCRIPTDIR and PATCHDIR instead of hardcoded file/directory
names. (suggested by will)
- Fix maxchars checker that has been broken.
- Fix "use ldconfig with ||/usr/bin/true" checker. (patch submitted by
sobomax)
- Fix "include the country code in the module alias name" warning.
Besides, "country code" is corrected to "language code".
- Add french and hebrew to the list of lang-specific categories.
- Properly omit the checks against PORTNAME section etc. when the
testee is a slave port.
- Add "INSTALLS_SHLIB may be missing" checker which searches pkg-plist
for `*.so' and `*.so.<nn>'.
- Make it dynamically read bsd.sites.mk so that we no longer need to
keep it always in sync with bsd.sites.mk. It now should recognize
`/%SUBDIR%/' part too.
- Change `split(/\s+/, "blah blah blah")' to `qw(blah blah blah)'.
- Add some dummy comments that prevent Emacs' CPerl mode from
confusing.
- Add a condition "unless this is a master port" to the warnings that
are specific to master ports, because currently we can't know if a
port is a master port.
Reviewed by: mharo (MAINTAINER)
- better rcsid checking
- add DIST_SUBDIR to section 1 of the Makefile
- add check for WWW: in pkg/DESCR when http:// exists
- add new -t flag, which will require a tab after a variable defination instead
of spaces
- cleanup english grammar
- add -M (make variable passing) flag
- change into portdir instead of constantly using $portdir/file
- get variables from make instead of parsing the Makefile
- update usage()
- fix some portname/version bugs
- add EXTRACT_ONLY to section 1
- fix multi comment sections on top bug
I think I'm going to start a rewrite of lots of portlint's code to
*hopefully* make it easier to add new checks in the future. If you
have any requests of things for me to put on portlint's TODO list,
send me an email letting me know what they are.
Fixes:
* fix some portname/version checking bugs
* put EXTRACT_ONLY in section 1 checking
* fix multi comment sections at top of Makefile regex
* make portlint pass perl -w (this found a few bugs)
No new features in this version
isn't 100% ready for prime time, but it works well enough that it should
be fine to use for most things. I'm not sure if I'll have time to fix
the few minor bugs that I know of and give it a good testing today.
Parts of the PORTNAME/PORTVERSION changes were submitted by knu.
Other changes in this version:
* add "-V", version flag
* use getopts instead of parsing @ARGV
- this fixes a bug where you could only specify one flag after the
dash (ie. -c -N would work and -cN wouldn't)
* change some warnings to fatals
* ignore dot directives in Makefile
- this usually reduces the number of warnings displayed when
a Makefile contains .include or .if foo
* don't blame just emacs for leaving around temporary editor files
* don't warn about installing files into /compat
* correct counting of number of chars in pkg/COMMENT
* understand multiple rcsid tags in the comments section
- this allows us to have both $FreeBSD$ and $NetBSD$, for example
without getting funky warning messages
* scope variables with my instead of local so we can use strict to
help us find bugs in portlint
portlint port passing portlint)
New portlint features:
* Allow pkg/COMMENT to start with a digit
* Warn about .la files in pkg/PLIST
* Better support for comments in the Makefile
- fixes the section off by 1 error
(DISTNAME needs to exist, and so on, when it does)
* don't report "FATAL: no MAINTAINER listed in Makefile" when it does exist
* other random minor bug fixes
- enforce pkg/COMMENT style
- better info file checking in pkg/PLIST
- don't warn about @unexec rmdir foo || true - the handbook says this is fine
- allow CATEGORIES+=
- warn about www.freebsd.org/~user needing to be people.freebsd.org
- warn about PKGNAME being set from another variable instead of being a
fatal error
- understand both $(PORTSDIR) and ${PORTSDIR}
