to avoid running SVN multiple times with command lines like the
following:
svn co --depth empty svn+ssh://svn.freebsd.org/ports/head ports
Reported by: ak@ (on IRC)
- FIX: all progress and error output goes to fd#2 (stderr)
- FIX: at top level, properly detect commands if preceded by options
- FIX: in checkstatus(), handle ~ (obstructed versioned item)
- FIX: support blanks, leading dashes, and shell meta characters:
+ in file names, so as not to choke the script on difficult file names
+ in command line arguments, so that svn commit -m "commit message" works,
rather than complaining about an unversioned file "message".
- FIX: in checkstatus(), keep leading spaces from svn status
- FIX: in setprop(), detect egrep errors, rather than assuming "no match"
- ADD: die if "check" psvn-specific command has trailing arguments
- CHANGE: replace `...` by more concise $(...) notation
- CHANGE: take maintainership, offered by beat@.
- SPEEDUP: in checkstatus(), use shell built-ins, rather than commands
- SPEEDUP: when checking files, run svn only once, rather than for each file
- SPEEDUP: when skipping "svn rm"-ed files, use ! -e rather than head|awk
- TODO: handle long options for svn commit
- TODO: do not stomp over svn:mime-type if it's already set (binary files!)
Approved by: beat@ (maintainer)
This was required with CVS, since the category was checked out as a module, but
the directory name is used with svn.
For example:
pcvs co ports_ports_mgmt
svn co $ports/head/ports-mgmt
Submitted by: swills
Approved by: vd (maintainer)
- Make the diff output work
- Use cdiff if exists, otherwise stick with $EDITOR
- Stop trying to remove CVSROOT; hasn't been checked out since modules
support was removed by erwin
pointyhat, but is intended for pointyhat-[west|east] to be able to
remove no longer needed specialized -exp runs. (They remain in the
errorlog archive; they can merely be removed from zfs.)
Replace this test with an anti-foot-shooting measure so that you cannot
remove 'latest' unless you have already removed 'previous'.
clang". This will probably need to be trimmed down some so as to not
pessimize processing time.
At this time this change will be restricted to pointyhat-west.
- deprecate assert, chown, perl5, python, stdio, sysvipc, varargs
- add the existing nested_declaration, termios, utmp_x
While here, fix formatting.
Pointy hat to: linimon, for letting this get so far out of sync
chown, perl5, python, stdio, struct changes, sysvipc, USE_XLIB, varargs
Add the following new error types that we are now seeing:
clang-bug, cpusetsize, sem_wait
Tweak the definitions for linker_error and threads to be more accurate.
to processonelog (not yet committed):
clang
clang-bug
cpusetsize
sem_wait
The former two will show up if an -exp run is done with clang as the default
ports compiler, instead of gcc. The latter two seem to be ports regressions
in 9-CURRENT.
was handled the same as "waiting for chroot" and retried. In certain
circumstances (e.g. a prerequisite package shown as being avaialable
when it really wasn't), this would cause a package build to loop
forever.
Note to future generations: I did not write this code.
Feature safe: yes
was being done before the src tree had been mounted.
This was not a problem in the old codebase, since it simply got the
wrong src tree to start with.
This actually simplifies the code.
and client-side definitions into common.conf.
While here, slide the 7-stable release to 7.3. This was driving me
crazy while trying to debug the INDEX and duds problems.
definitions and the client-side definitions.
While here, add ARCHS_SUPPORTING_COMPAT_IA32, which is needed to get
linux emulation ports to be properly detected on head nodes that are
build from first principles (e.g. !pointyhat).
nodes that don't have /usr/src. On pointyhat, this "just happens to
work"; on a cleanly installed system like pointyhat-west, it didn't.
Add overrides for Linux compatibility (again, it "just happened to work"
on pointyhat).
Move the code that sets PORTSDIR and SRC_BASE to the server side only.
The code that overrides OSVERSION, OSREL, and BRANCH _must_ remain in
the common code.
one 'head' node, rather than just pointyhat itself.
Constants are factored out into installation-specific files known as
portbuild/conf/server.conf and portbuild/conf/client.conf. There is
only one server.conf file. Individual <arch> directories may have
their own client.conf files, or may symlink to ../conf/client.conf.
NOTE: these scripts are not yet parameterized, so this is WIP.
Feature safe: yes
one 'head' node, rather than just pointyhat itself.
Constants are factored out into installation-specific files known as
portbuild/conf/server.conf and portbuild/conf/client.conf. There is
only one server.conf file. Individual <arch> directories may have
their own client.conf files, or may symlink to ../conf/client.conf.
Several bugs are fixed and improvements are made:
- parameterize everything.
- switch to csup. (This necessitates pushing the repos down one
directory level, e.g. ports-head/ports and src/src-8. However,
this will give us the flexibility to have e.g. src/src-8.1 in
the future.)
- note that the misnomer filename 'cvsdone', which was created
here, is now changed to '.updated'.
Feature safe: yes
one 'head' node, rather than just pointyhat itself.
Constants are factored out into installation-specific files known as
portbuild/conf/server.conf and portbuild/conf/client.conf. There is
only one server.conf file. Individual <arch> directories may have
their own client.conf files, or may symlink to ../conf/client.conf.
While here, do some refactoring.
Feature safe: yes
one 'head' node, rather than just pointyhat itself.
Constants are factored out into installation-specific files known as
portbuild/conf/server.conf and portbuild/conf/client.conf. There is
only one server.conf file. Individual <arch> directories may have
their own client.conf files, or may symlink to ../conf/client.conf.
Note the change of the misnomer filename 'cvsdone' to '.updated'.
Feature safe: yes
one 'head' node, rather than just pointyhat itself.
Constants are factored out into installation-specific files known as
portbuild/conf/server.conf and portbuild/conf/client.conf. There is
only one server.conf file. Individual <arch> directories may have
their own client.conf files, or may symlink to ../conf/client.conf.
Several bugs are fixed and improvements are made:
- suppress error message if there are no logs yet.
- change the misnomer filename 'cvsdone' to '.updated'.
- fix a bug by un-escaping '_' in the timestamp.
Feature safe: yes
one 'head' node, rather than just pointyhat itself.
Constants are factored out into installation-specific files known as
portbuild/conf/server.conf and portbuild/conf/client.conf. There is
only one server.conf file. Individual <arch> directories may have
their own client.conf files, or may symlink to ../conf/client.conf.
While here, fix error messages displayed on new runs.
Feature safe: yes
one 'head' node, rather than just pointyhat itself.
Constants are factored out into installation-specific files known as
portbuild/conf/server.conf and portbuild/conf/client.conf. There is
only one server.conf file. Individual <arch> directories may have
their own client.conf files, or may symlink to ../conf/client.conf.
*very* carefully note where the exported variables are consumed.
Several bugs are fixed and improvements are made:
- the file UNAME_VERSION appears unused, so it is removed. The
information is passed in overrides to uname(1).
- parameterize arch-specific setup code.
Feature safe: yes
one 'head' node, rather than just pointyhat itself.
Constants are factored out into installation-specific files known as
portbuild/conf/server.conf and portbuild/conf/client.conf. There is
only one server.conf file. Individual <arch> directories may have
their own client.conf files, or may symlink to ../conf/client.conf.
Feature safe: yes
one 'head' node, rather than just pointyhat itself.
Constants are factored out into installation-specific files known as
portbuild/conf/server.conf and portbuild/conf/client.conf. There is
only one server.conf file. Individual <arch> directories may have
their own client.conf files, or may symlink to ../conf/client.conf.
Note the removal of the hard-coding of INDEX.N, where N has to be
a single digit, and also have no '.' in it.
Feature safe: yes
one 'head' node, rather than just pointyhat itself.
Constants are factored out into installation-specific files known as
portbuild/conf/server.conf and portbuild/conf/client.conf. There is
only one server.conf file. Individual <arch> directories may have
their own client.conf files, or may symlink to ../conf/client.conf.
Note the very special handling of cvs tag.
Feature safe: yes
one 'head' node, rather than just pointyhat itself.
Constants are factored out into installation-specific files known as
portbuild/conf/server.conf and portbuild/conf/client.conf. There is
only one server.conf file. Individual <arch> directories may have
their own client.conf files, or may symlink to ../conf/client.conf.
Fix the sed script to correctly handle '.' in branch directory names.
Feature safe: yes
one 'head' node, rather than just pointyhat itself.
Constants are factored out into installation-specific files known as
portbuild/conf/server.conf and portbuild/conf/client.conf. There is
only one server.conf file. Individual <arch> directories may have
their own client.conf files, or may symlink to ../conf/client.conf.
Gracefully handle the case of INDEX failing to build. This helps the
calling script to exit instead of spewing errors.
Feature safe: yes
one 'head' node, rather than just pointyhat itself.
Constants are factored out into installation-specific files known as
portbuild/conf/server.conf and portbuild/conf/client.conf. There is
only one server.conf file. Individual <arch> directories may have
their own client.conf files, or may symlink to ../conf/client.conf.
Add the copying over of client.conf to the clients, and take care
to force the file copy regardless of whether it is a symlink.
Feature safe: yes
one 'head' node, rather than just pointyhat itself.
Constants are factored out into installation-specific files known as
portbuild/conf/server.conf and portbuild/conf/client.conf. There is
only one server.conf file. Individual <arch> directories may have
their own client.conf files, or may symlink to ../conf/client.conf.
Several bugs are fixed and improvements are made:
- the name of the journal is changed from 'make' (ew) to 'journal'.
- 'cvsdate' is replaced by the more accurate name '.updated' and
documentation adjusted to match.
- make it more clear that '.updated' means 'ports tree updated'
instead of 'src tree updated' (although the same filename is
used for both).
- correctly handle the general case of non-mainstream branches
(e.g. "7-exp") without hardcoding "-exp".
Feature safe: yes
one 'head' node, rather than just pointyhat itself.
Constants are factored out into installation-specific files known as
portbuild/conf/server.conf and portbuild/conf/client.conf. There is
only one server.conf file. Individual <arch> directories may have
their own client.conf files, or may symlink to ../conf/client.conf.
Note: the major change is to require branch as an argument. The
silly code that expected the branch to be passed via a symlinked
command such as 'dopackages.7' is removed.
Several bugs are fixed and improvements are made:
- make the separation of 'date' and 'datestamp' clearer.
- make handling of error conditions (e.g. for a first-time run
where 'build create' has been forgotten) more obvious.
Feature safe: yes
one 'head' node, rather than just pointyhat itself.
Constants are factored out into installation-specific files known as
portbuild/conf/server.conf and portbuild/conf/client.conf. There is
only one server.conf file. Individual <arch> directories may have
their own client.conf files, or may symlink to ../conf/client.conf.
Several bugs are fixed and improvements are made:
- the name of the journal file is changed from 'make' (ew) to
'journal'.
- the 'date' parameter becomes 'datestamp' to delinate the script's
uses of the date command vs. the parameter. This is mostly for
readability.
- add the -nochecksubdirs option. This is only useful for restarted
or incremental runs.
- refactor the error returns a bit.
- exit gracefully if no INDEXFILE.
- fix a bug in the 'packages built' logic that would return -2 if no
packages were actually built.
- change the misnamed 'cvsdone' file to '.updated'.
- clean up the 'task waiting' logic.
Feature safe: yes
one 'head' node, rather than just pointyhat itself.
Constants are factored out into installation-specific files known as
portbuild/conf/server.conf and portbuild/conf/client.conf. There is
only one server.conf file. Individual <arch> directories may have
their own client.conf files, or may symlink to ../conf/client.conf.
Note that this script will now figure out 'branches' by itself, thus
removing the special-casing for '-exp'.
Feature safe: yes
one 'head' node, rather than just pointyhat itself.
Constants are factored out into installation-specific files known as
portbuild/conf/server.conf and portbuild/conf/client.conf. There is
only one server.conf file. Individual <arch> directories may have
their own client.conf files, or may symlink to ../conf/client.conf.
Note: it is still not clear to me if this script is currently used.
Feature safe: yes
one 'head' node, rather than just pointyhat itself.
Constants are factored out into installation-specific files known as
portbuild/conf/server.conf and portbuild/conf/client.conf. There is
only one server.conf file. Individual <arch> directories may have
their own client.conf files, or may symlink to ../conf/client.conf.
While here, rework the code a bit to parameterize arch-specific tasks.
Feature safe: yes
one 'head' node, rather than just pointyhat itself.
Constants are factored out into installation-specific files known as
portbuild/conf/server.conf and portbuild/conf/client.conf. There is
only one server.conf file. Individual <arch> directories may have
their own client.conf files, or may symlink to ../conf/client.conf.
While here, carefully document the origin of the values of the
environment variables that are passed in.
Feature safe: yes
one 'head' node, rather than just pointyhat itself.
Constants are factored out into installation-specific files known as
portbuild/conf/server.conf and portbuild/conf/client.conf. There is
only one server.conf file. Individual <arch> directories may have
their own client.conf files, or may symlink to ../conf/client.conf.
While here, do some cleanup.
Feature safe: yes
one 'head' node, rather than just pointyhat itself.
Constants are factored out into installation-specific files known as
portbuild/conf/server.conf and portbuild/conf/client.conf. There is
only one server.conf file. Individual <arch> directories may have
their own client.conf files, or may symlink to ../conf/client.conf.
Several bugs are fixed and improvements are made:
- the definitions for valid 'arch' and 'branch' are moved to
server.conf.
- the script is broken up into two pieces; the old 'buildenv' name
becomes the server side, and 'buildenv.client' is add for the
client side. 'buildenv.common' is what you would expect. This
makes the separation of what controls what more clear.
- the concept of 'branch base' is generalized to match any pattern
postpended with '-', thus removing the specialness of '-exp'. More
work remains on the other scripts to best take advantage of this.
- as a corollary, 'branch' can also have '.' in it, e.g., 6.4.
- the obsolete variables FTP_PASSIVE_MODE, PKGZIPCMD, and X_WINDOW_SYSTEM
are removed.
Feature safe: yes
one 'head' node, rather than just pointyhat itself.
Constants are factored out into installation-specific files known as
portbuild/conf/server.conf and portbuild/conf/client.conf. There is
only one server.conf file. Individual <arch> directories may have
their own client.conf files, or may symlink to ../conf/client.conf.
Several bugs are fixed and improvements are made:
- archive directories are created if they do not exist.
- the location of ZFS-based directories is generalized.
- the special string "-exp" disappears.
- handling of buildid is made more robust.
Feature safe: yes
one 'head' node, rather than just pointyhat itself.
Constants are factored out into installation-specific files known as
portbuild/conf/server.conf and portbuild/conf/client.conf. There is
only one server.conf file. Individual <arch> directories may have
their own client.conf files, or may symlink to ../conf/client.conf.
While here, fix a but in the handling of the 'all' case.
Feature safe: yes
one 'head' node, rather than just pointyhat itself.
Constants are factored out into installation-specific files known as
portbuild/conf/server.conf and portbuild/conf/client.conf. There is
only one server.conf file. Individual <arch> directories may have
their own client.conf files, or may symlink to ../conf/client.conf.
This first set of files only gets the *.conf files and some cleanup.
Feature safe: yes
building server. For security reasons, the scripts themselves will
not be checked in to this repository.
Please do not commit to this file without the approval of portmgr.
Feature safe: yes
used from a package building cluster. This is part of a rewrite to remove
a great deal of hardcoding.
Please do not commit to this file without the approval of portmgr.
Feature safe: yes
a package building cluster. This is part of a rewrite to remove a great
deal of hardcoding.
Please do not commit to this file without the approval of portmgr.
Feature safe: yes
Note: all 3 of these files will be changing radically in the near future.
This is the last checkin from the "classic" codebase installation.
Feature safe: yes
nodes, but most regularly on sparc64. (Occasionally, on amd64 and ia64).
For reasons I haven't been quite able to track down, on some occasions
a pkg_add command is unable to extract a dependency; the tarfile shows
up as being truncated. This does not seem to be due to disk-low or
memory-low conditions, nor is it a problem with scp; the md5 on the file
is fine when examined afterwards.
The only clue so far is that it seems to happen on systems with the most
package builds running simultaneously -- and thus, possibly more than one
pkg_add running in parallel.
analyzed for how much they will slow this script down; consider this a
rush-job.)
- dirent denotes some change in the usage of dirent.h.
- termios denotes the deprecation of <sys/termios.h>.
- uname denotes the hiding of the uname symbol. This has been backed
out in src so let's hope this case can go away soon.
- utmp_x denotes the replacement of utmp.h with utmpx.h.
Together these catch ~150 new errors on i386-9. However, there are more
that are not caught (second-order effects.)
available on the ftp mirrors alongside the packages [1]
- While I'm here, remove a NOOP check for FreeBSD 4.x -exp
PR: 135024 [1]
Requested by: Dominic Fandrey <kamikaze@bsdforen.de>
- bring this closer to the default FreeBSD page style
- remove unsupported releases
- remove the date stamps, which no longer work
- remove obsolete commented-out junk
Discussed on: portmgr, some time ago
list : lists available builds
clone : creates a new build by cloning a previous one
portsupdate : update a ports tree to the latest ZFS snapshot
srcupdate : update a src tree to the latest ZFS snapshot
cleanup : clean up or remove a build on the clients
destroy : remove a build on the server
There is some trickiness here in that various commands either expect
to run as root, or expect to run as a ports-* user. For the latter
case we can easily use su to proxy as the ports user when running as
root; for the former we use the buildproxy to validate and re-execute
the command as root.
the ports-* users. Currently it is not possible to delegate
management of ZFS filesystems to non-root users, so root privilege
is required to manipulate them. We validate the command passed on
a local domain socket and re-execute the build script with the requested
parameters.
ports and source trees. Since we have >=1 consumer of these trees
that run frequently but do not insist on up-to-the-second trees, it
makes sense to "pre-update" them regularly and then then re-use in all
of the consumers, instead of potentially doing several updates
simultaneously or on demand. Consumers can clone the ZFS snapshot
into their local filesystem which takes a couple of seconds instead of
minutes or tens of minutes for the CVS update.
We update to a date stamp instead of "." because this avoids
ambiguity of commits that happen while the tree update is in progress
(unfortunately it's slower).
listed filesystem we take a new snapshot each time it is run and if
the last full backup was not too long ago, do a compressed incremental
backup from the previous backup.
* Catch up to build ID directory changes
* Support a meta-hostname of 'all' for setting up all clients at once.
This is better than the old way of running one copy of the script
for each client by hand, since it is easier and involves less
duplicated work.
* We copy in the per-build ports, src, and bindist .tbz files and .md5
checksums, as well as refreshing the build scripts and
bindist-$(hostname).tar customization tarball.
* The -force switch forces copying of files and re-extraction of the
tarballs on the client. This is necessary in order to propagate
local changes to the tarballs after the initial client setup
(e.g. if you need to change a file in the ports tree, it must be
recompressed, redistributed, and re-extracted on the client).
* The -queue switch will poll the client's job queue after completion
of the setup. This is racy and should only be used when the machine
is not currently accepting jobs.
* For cleaning up a build the 'build cleanup' command should now be
used instead. It calls back into this command but also allows full
clenaup of build-local files on the client.
TODO: "all" setups are hard on the server since they may spawn dozens
of rsyncs at once. A better solution would be to have a worker pool
of setup tasks to limit the maximum load.
* Catch up to build ID directory changes
* Make it easier to kill a build by not running dopackages in the background
where it is detached from shell job control. Now, sending a termination
signal to this process (e.g. ^C) will also kill off the dopackages script
and in turn the processes created by it. Some background processes
spawned by dopackages, pdispatch, etc, may still remain and need to be
killed by hand.
* Catch up to build ID directory changes
* Improve usage()
* Fix a variety of small bugs
* Remove support for -ftp builds: we have not supported direct
uploading for many years due to the desire to manually inspect build
output for quality
* All data associated to a build is now localized in its own directory
named according to a build ID:
/var/portbuild/${arch}/${branch}/builds/${buildid}, where ${buildid}
is the creation time. These are actually ZFS filesystems.
* Tasks such as cloning a new build, updating a ZFS snapshot, and
cleaning up a build are exported to the "build" script, which can be
used independently.
* Creating a new build is done by ZFS cloning and takes a couple of
seconds since it is copy-on-write (i.e. no data needs to be copied).
* Ports and source trees are also cloned from pre-updated ZFS images
(updated regularly from the "updatesnap" cron job). In most cases
we do not care if we are building a ports tree that is an hour or so
old since it will become outdated almost immediately anyway, so no
matter what we do there will be times when a port has been fixed by
the time the build error is generated by a client.
* In case an up-to-the-second tree is desired, the -portscvs and
-srccvs switches update the existing ports tree via CVS.
* -noports and -nosrc can be used to prevent any automatic changes to
the ports tree. This is useful for dealing with local
modifications (e.g. for -exp builds), since the default when
creating a new build is to replace the previous trees with fresh,
pristine trees. If you forget to use this then any local changes
that are not also present in other trees will be lost.
* By default we keep two builds for each arch/branch pair. These
build IDs also may be referred to via "latest" and "previous"
symlinks. When creating a new build, the old "previous" build is
destroyed by default, unless it was originally created using the
-keep switch. This prevents the build from being destroyed
automatically.
* By default when a build finishes all of the clients are completely
cleaned up (i.e. all build data such as ports trees, tarballs,
client chroots, etc are deleted). This is needed to save space on
the clients. If you expect to *immediately* perform further builds
after this one completes, the -nocleanup switch prevents this step.
Otherwise they will just be set up again if further builds are
scheduled.
* Try to parallelize build pre-processing as much as possible, by
running jobs in the background wherever possible. In several places
we operate on the same parts of the filesystem from multiple jobs,
so we can make good use of caching to improve performance
* Clients no longer need to be set up explicitly at the start of the
build, they will be set up on-demand when the first job is
dispatched to them. This allows fast clients or those that already
have been set up to begin building ports as soon as possible, while
slow clients are set up in the background. It also improves
robustness of client recovery, e.g. if the client was offline at the
time of build startup but later brought back online.
* Optimize copying back in the previous set of restricted packages by
hardlinking instead of copying.
TODO: The record of failed ports is arch/branch-global still. This is
the only thing preventing us from running concurrent builds of the
same arch/branch (e.g. while one is stuck building openoffice, the
next build can start to keep the cluster busy). The difficulty is
that one build from a later ports tree may signal that a build was
successful, then a phase 2 build from an earlier ports tree may
indicate that it was broken. The solution is probably to migrate this
to a real database instead of a flat file, and query it for the set of
broken ports as of a certain ports tree date.
* Clients no longer mount ports/src trees via NFS (even the FreeBSD.org
local clients). This was putting too much load on the server and
slowing down builds.
* Instead ports and src .tbz files are pushed to the clients and
unpacked. MD5 checksums are used to verify correctness
* -force forces re-extraction of the tarballs even if they exist and
appear to be checked out
* Also unpack the compressed bindist
TODO: When we are not using md or ZFS builds it would be even faster
to keep an unpacked copy of the bindist on the scratch filesystem and
hardlink the files into the target directory
* Catch up to build ID directory changes
* Improved support for ZFS builds
* Improved robustness
* Report status verbosely to the caller; whether we succeeded in claiming
a chroot, whether the caller needs to first set up the client, or
whether a setup is in progress.
* If we discover that the client has not been set up either because it
freshly booted and newfs'ed its filesystem, or because a particular
build has not yet been encountered, atomically claim a cookie and
report this to the caller to act on
* Catch up to build ID directory changes
* Add helper functions for resolving a build ID symlink and
validating an arch/branch combination (centralize instead of doing it
in many scripts)
