Remove patches that were upstreamed
xymon-client rc script: leftover children auto expire after 5 minutes;
remove stop_postcmd
Special thanks to JC Cleaver who is taking upstream Xymon to new and
exciting places.
script duplicates much of the rc script and adds unnecessary complexity.
While here ensure that leftover processes are cleaned up.
This also fixes a recent regression which prevented xymon-client from
reliably starting on boot.
PR: 197827
While xymon-client knows internally what UID it should run as, a
design flaw in the rc script was still launching its master process as
root. As a result the following two processes were always running as
root instead of the xymon user:
/usr/local/www/xymon/client/bin/xymonlaunch ...
sh -c vmstat 300 2 ...
The rest of the processes the xymon-client runs such as df, netstat,
top, custom scripts, etc were correctly executing as non-root.
changed cp to exit with a non-zero exit code if the file exists and is not
overwritten thus causing ports to fail installing when e.g. trying to cp
.default -> .conf files that already exist.
We just ignore the error and continue, as we used to.
Reported by: jaset
Approved by: portmgr (bapt)
literal name_enable wherever possible, and ${name}_enable
when it's not, to prepare for the demise of set_rcvar().
In cases where I had to hand-edit unusual instances also
modify formatting slightly to be more uniform (and in
some cases, correct). This includes adding some $FreeBSD$
tags, and most importantly moving rcvar= to right after
name= so it's clear that one is derived from the other.
constructions that parse out to [ -z "$foo" ] && foo=""
These are bad examples that get copied and pasted into new code, so the
hope is that with less bad examples there will be less need for me to
bring this up in review.
In a few of these files all that were changed were comments so that next
time I search for these patterns I won't trip on the file for no reason.
In a few places, add $FreeBSD$
No functional changes, so no PORTREVISION bumps
