The latest commits broke this port on DragonFly. The port uses the
base mk files rather than a standalone makefile, and will not build
without warnings appearing:
gpxloggerd.c:185:16: error: variable 'pt' set but not used
[-Werror=unused-but-set-variable]
To ensure -Werror flag is not passed to the build, set NO_WERROR for
the makefile.
Approved by: blanket (-Werror, restore DF)
When using GH_TAGNAME the DISTNAME would have GH_PROJECT and GH_ACCOUNT in
it. When not using GH_TAGNAME it would not have this. Now both cases
will add in the GH_PROJECT and GH_ACCOUNT.
Add special care to ensure that the DISTVERSION is not added in twice. If
a port does GH_TAGNAME=v${PORTVERSION} it will be added in twice though. For
that case DISTVERSIONPREFIX=v should be set and no GH_TAGNAME should be used.
empty() is used rather than (!defined || !${}) to support fmake.
The purpose of setting DISTNAME at all in these cases is to make it more clear
that the distfile is from *GITHUB* and to avoid collisions if a project were
to be renamed or moved. Without adding in GH_PROJECT and GH_ACCOUNT then there
are real risks that collisions on filenames would happen on renamed or moved
projects, which is fairly common. A GITHUB-generated file may not match
a custom-rolled or git-archive-rolled distfile.
PR: 199069
With hat: portmgr
Testing done: All USE_GITHUB ports without GH_COMMIT were checksum/fetch/extract/WRKSRC tested.
r381648 which were expecting DISTVERSIONPREFIX/SUFFIX to be used in the
tag fetched from github by defaulting GH_TAGNAME to the same value
as DISTVERSION would get by only when GH_COMMIT is not set (when using the
new scheme).
With hat: portmgr
The new GITHUB MASTER_SITE from r381618 now supports not setting GH_COMMIT and
only having GH_TAGNAME default to DISTVERSION.
All of these ports as-is.
With hat: portmgr
- Fixes indirect linking errors on modern binutils (fix from dports)
- Trim Makefile header and canonicalize creator's name
- Remove leading article from COMMENT
- Remove unnecessary library version in LIB_DEPENDS
Approved by: culot (mentor), maintainer
literal name_enable wherever possible, and ${name}_enable
when it's not, to prepare for the demise of set_rcvar().
In cases where I had to hand-edit unusual instances also
modify formatting slightly to be more uniform (and in
some cases, correct). This includes adding some $FreeBSD$
tags, and most importantly moving rcvar= to right after
name= so it's clear that one is derived from the other.
The gpxloggerd is a tiny daemon that connects to gpsd(8) and logs
received fix information in the GPX format.
PR: ports/151308
Submitted by: glebius
Approved by: pgollucci (mentor, implicit)
