Commit graph

50 commits

Author SHA1 Message Date
Joe Marcus Clarke
debac8b327 Ack, I knew I forgot something. Add a new -C argument that enables pedantic
committer mode.  This is the identical to -A except it omits the new port
checks.

Requested by:	eik
2003-11-22 20:38:55 +00:00
Joe Marcus Clarke
c2d31c5361 Standardize all error messages to include the filename at least (and line
number where possible).  Bump version to 2.5.2.

Reviewed by:	eik
2003-11-22 20:29:03 +00:00
Joe Marcus Clarke
22030dac05 * Check to make sure new ports do not contain PORTREVISION [1]
* Check to make sure new ports do not contain PORTEPOCH
* Throw a FATAL error if an additional file exists in the port directory but
  not in CVS [2]
* Throw a FATAL error if a file is in CVS but not in the port's directory [2]
* Throw a FATAL error if a file was deleted from CVS but still in the port's
  directory [2]
* Warn if a new file contains a non-empty RCS Id [2]
* Add a missing ``if ($verbose)'' [2]

Submitted by:	arved [1]
		eik [2]
2003-11-21 02:55:08 +00:00
Joe Marcus Clarke
1f93b36619 Update to 2.5.0.
* Add some linenumbers to the whole file search
* Hack the direct command use code some more
* Add a check for the deprecated USE_MESA
* Allow PKGCATEGORY not in CATEGORIES [1]
* Allow %B in pkg-plist, as it has a valid prefix [1]
* Allow simple rm -f, it needs no redirection [1]
* Add portlintgrep.pl, an example on how to use portlint to find certain
  portlint problems in the ports tree [2]

Submitted by:	dinoex [1]
		eik [2]
2003-11-17 20:17:46 +00:00
Joe Marcus Clarke
be2f66b2f4 * Update to 2.4.8
* Add a check to make sure the last line of a slave port's Makefile contains
  an appropriate MASTERDIR include directive [1]
* study() the $whole string to improve performance [1]
* Fix the search for direct command use
* Check for ports that may break INDEX [1]
* Check for GNOME ports that use pre-patch and gnomehack

Submitted by:	eik [1]
2003-11-15 22:12:00 +00:00
Joe Marcus Clarke
12a03d742d * Add support for the arabic category [1]
* Check for variables that are used too late [1]
* Rename some of the language variables.  Admittedly, this needs more work.
* Check for anything after bsd.port(.post).mk [1]
* Fix the language category search code
* Bump version to 2.4.7

Submitted by:	Oliver Eikemeier <eikemeier@fillmore-labs.com> [1]
2003-11-09 00:44:31 +00:00
Joe Marcus Clarke
5b8604bff3 Whoops. Flush out my CVS repo, and share some missing bug fixes with the
rest of the world.

* Fix the -V option in the manpage [1]
* Handle the case where parentheses may not exist around NOPORTDOCS [2]
* Bump version to 2.4.6

Submitted by:	mat [1]
Reported by:	kris [2]
2003-11-01 22:46:25 +00:00
Joe Marcus Clarke
694151221a Recognize .ifndef(NOPORTDOCS) as well as .if !defined(NOPORTDOCS).
Reported by:	kris
2003-10-27 01:58:39 +00:00
Joe Marcus Clarke
abada95d3c * Add some @unexec checking for plists [1]
* Check for the common typo, NOPORTSDOC [2]
* Make sure .CURDIR is the primary category [3]
* Check for USE_* macros that are user-settable [4]
* Try to be a little more intelligent when checking for macros that need to
  appear earlier
* Ignore make directives when checking for extra items in certain sections

PR:		55921 [1]
		57751 [2]
		58292 [3]
		58525 [4]
Submitted by:	edwin [1]
		Oliver Eikemeier <eikemeier@fillmore-labs.com> [2] [3] [4]
2003-10-26 21:27:30 +00:00
Joe Marcus Clarke
dd5ea45c77 Update to 2.4.4.
* Add support for the Polish locale
* Try to add more intelligence to the direct command use code
* Fix up the wording about numbered info files [1]

Suggested by:	gerald [1]
2003-08-16 20:42:44 +00:00
Joe Marcus Clarke
12a8b0c085 Really fix the bug where portlint looks through COMMENT for direct command
usage.
2003-08-15 17:47:21 +00:00
Joe Marcus Clarke
0bd33bd673 * Add support for the new INFO macro
* Clean up some more Perl warnings
* Make sure all the MAN macros are printed in all uppercase
* Add perl, ruby, python, and the auto* tools to the list of direct
  commands [1]

PR:		55529 [1]
Submitted by:	Jens Rehsack <rehsack@liwing.de> [1]
2003-08-15 05:05:33 +00:00
Joe Marcus Clarke
18bbfe40c0 Update to 2.4.1.
* Document the -V option [1]
* Properly suggest ${STRIP_CMD} (not ${STRIP}) instead of strip [2]
* Correct the version string

PR:		54993 [1]
Submitted by:	Mark Linimon <linimon@lonesome.com> [1]
		gerald [2]
Pointy hat to:	me [2] (I should have used Gerald's patch as-is)
2003-07-28 20:23:32 +00:00
Joe Marcus Clarke
bebd089421 Update to 2.4.0.
* Document the -A option in the usage
* Add my name to the list of AUTHORS
* Clean up some warnings produced by perl -cwT
* Check for the existence of pkg-comment and flag it as FATAL [1]
* Add OMF checking support similar to the info checking code
* Add support for {DOCS,EXAMPLES}DIR macros [2]
* Don't check commented out URLs in MASTER_SITES [3]
* Add file, find, strip, and xargs to the list of direct command names [4]
* Don't search for command names in COMMENT [5]
* Add SITE_PERL support [6]
* Add DISTFILE/MASTER_SITE grouping support [7]
* Check to make sure the MAINTAINER field contains a valid email address
* Add support for {EXTRACT,PATCH}_DEPENDS
* Add USE_GETOPT_LONG support [8]

PR:		48199 [1]
		53371 [2]
		43537 [3]
		54381 [6]
		39487, 44099, 48221 [7]
		54497 [8]
Submitted by:	Sergei Kolobov <sergei@kolobov.com> [2] [8]
		gerald [4] (file and strip)
		Oliver Eikemeier <eikemeier@fillmore-labs.com> [6]
Reported by:	kris and nork [5]
2003-07-20 00:31:20 +00:00
Pete Fritchman
0b19c78609 - warn about incorrect usage of the pre-everything:: target
- don't give a warning to use binary mode because of a possible RCS tag
  if the tag is $FreeBSD$.
- bump PORTREVISION

Approved by:	maintainer timeout, portmgr (kris)
2003-03-07 17:00:43 +00:00
Kris Kennaway
dd95676c27 Catch up to new COMMENT semantics (contains comment string instead of
pointing to pkg-comment)

Submitted by:	lioux
2003-02-10 08:58:30 +00:00
Gerald Pfeifer
9bf9023ee4 Let the PORTSDIR environment variable override our defaults.
Approved by:	mharo (maintainer)
2003-02-02 21:17:40 +00:00
Akinori MUSHA
27754b5c4e Add a simple check for MAINTAINER not to include multiple addresses or
comments.

Approved by:	portmgr
2003-01-11 08:18:48 +00:00
Mario Sergio Fujikawa Ferreira
4345a7350f Add latest language categories: hungarian, portuguese and ukrainian
Approved by:	mharo (maintainer)
2002-11-18 21:28:12 +00:00
Anders Nordby
43e120b4b3 Add -A option for all additional checks.
Approved by:	(silence from) mharo
2002-11-18 02:37:30 +00:00
Michael Haro
2235407eff Teach portlint to recognize RUN_DEPENDS=${BUILD_DEPENDS} and the like
PR:		27182
Submitted by:	Anton Berezin <tobez@tobez.org>
2002-09-14 18:57:41 +00:00
Akinori MUSHA
77e106b384 Bring in the enhancements I submitted to mharo some time ago and bump
the version to 2.3.2.

- Add checks for empty files, empty directories, core files, more
possible backup files, dotfiles, symlinks and CVS directories.

- Do not assume PATCHDIR always includes "/files/".  Use the best
method to check whether a file is added to @checker as a patch file.

- Some trivial message style fixes.
2001-03-20 20:54:24 +00:00
FUJISHIMA Satsuki
afa075e6d8 o stop checking blank lines for files/patch-*
o fix getopt arguments: -B takes argument and -N don't.

Submitted by:		Peter Pentchev <roam@orbitel.bg>
Non-responce from:	maintainer
2001-02-17 12:20:32 +00:00
Michael Haro
1503c58d38 Fix docs
Submitted by:	olgeni
2001-02-14 10:56:10 +00:00
Michael Haro
87190a2217 fix some typos, make some warning messages more verbose
PR:		23725
Submitted by:	    Jimmy Olgeni <olgeni@uli.it>
2000-12-31 18:59:43 +00:00
Akinori MUSHA
2e9b5b7363 Update to version 2.3.
- Conform to the new port layout, finally.

- Use COMMENT, DESCR, PLIST, PKGINSTALL, PKGDEINSTALL, PKGREQ,
PKGMESSAGE, SCRIPTDIR and PATCHDIR instead of hardcoded file/directory
names. (suggested by will)

- Fix maxchars checker that has been broken.

- Fix "use ldconfig with ||/usr/bin/true" checker. (patch submitted by
sobomax)

- Fix "include the country code in the module alias name" warning.
Besides, "country code" is corrected to "language code".

- Add french and hebrew to the list of lang-specific categories.

- Properly omit the checks against PORTNAME section etc. when the
testee is a slave port.

- Add "INSTALLS_SHLIB may be missing" checker which searches pkg-plist
for `*.so' and `*.so.<nn>'.

- Make it dynamically read bsd.sites.mk so that we no longer need to
keep it always in sync with bsd.sites.mk.  It now should recognize
`/%SUBDIR%/' part too.

- Change `split(/\s+/, "blah blah blah")' to `qw(blah blah blah)'.

- Add some dummy comments that prevent Emacs' CPerl mode from
confusing.

- Add a condition "unless this is a master port" to the warnings that
are specific to master ports, because currently we can't know if a
port is a master port.

Reviewed by:	mharo (MAINTAINER)
2000-12-12 14:24:12 +00:00
Michael Haro
2beea6cfcb fix a bug, $i = -> $i eq
Submitted by:	fenner
2000-11-10 07:20:43 +00:00
Will Andrews
c0234049ca Add support for the new PORTEPOCH/PORTREVISION variables, so it won't
improperly fatal-warn about them being in PORTNAME area.

PR:		21747
Submitted by:	jeh
2000-10-10 23:54:49 +00:00
Michael Haro
93abd0a028 sync with bsd.sites.mk, bump version to 2.2.3
Submitted by: jeh
2000-10-04 04:02:39 +00:00
Will Andrews
89ac3f8bd9 Fix portlint bug where it thinks that missing a files/md5 is fatal but the
port actually does not have any DISTFILES variable.  This *should* work
with slave/master ports, but I'm not sure.

Now the portlint port passes its own test.  ;->

PR:		21380
Submitted by:	des
Approved by:	mharo
2000-09-21 16:22:15 +00:00
Michael Haro
de91bdd9c9 update to portlint 2.2.2:
- better rcsid checking
- add DIST_SUBDIR to section 1 of the Makefile
- add check for WWW: in pkg/DESCR when http:// exists
- add new -t flag, which will require a tab after a variable defination instead
  of spaces
- cleanup english grammar
- add -M (make variable passing) flag
- change into portdir instead of constantly using $portdir/file
- get variables from make instead of parsing the Makefile
- update usage()
- fix some portname/version bugs
- add EXTRACT_ONLY to section 1
- fix multi comment sections on top bug

I think I'm going to start a rewrite of lots of portlint's code to
*hopefully* make it easier to add new checks in the future.  If you
have any requests of things for me to put on portlint's TODO list,
send me an email letting me know what they are.
2000-04-25 21:33:42 +00:00
Michael Haro
98f1c93d32 Update to 2.2.1
Fixes:
	* fix some portname/version checking bugs
	* put EXTRACT_ONLY in section 1 checking
	* fix multi comment sections at top of Makefile regex
	* make portlint pass perl -w (this found a few bugs)
No new features in this version
2000-04-16 23:05:06 +00:00
Michael Haro
eee7229c03 Update portlint so it supports PORTNAME/PORTVERSION. This version
isn't 100% ready for prime time, but it works well enough that it should
be fine to use for most things.  I'm not sure if I'll have time to fix
the few minor bugs that I know of and give it a good testing today.

Parts of the PORTNAME/PORTVERSION changes were submitted by knu.

Other changes in this version:
	* add "-V", version flag
	* use getopts instead of parsing @ARGV
		- this fixes a bug where you could only specify one flag after the
		  dash (ie. -c -N would work and -cN wouldn't)
	* change some warnings to fatals
	* ignore dot directives in Makefile
		- this usually reduces the number of warnings displayed when
		  a Makefile contains .include or .if foo
	* don't blame just emacs for leaving around temporary editor files
	* don't warn about installing files into /compat
	* correct counting of number of chars in pkg/COMMENT
	* understand multiple rcsid tags in the comments section
		- this allows us to have both $FreeBSD$ and $NetBSD$, for example
		  without getting funky warning messages
	* scope variables with my instead of local so we can use strict to
	  help us find bugs in portlint
2000-04-16 20:24:40 +00:00
Michael Haro
8d3d318a69 * Fix Makefile so portlint is more happy with this port (what a concept, the
portlint port passing portlint)

New portlint features:
* Allow pkg/COMMENT to start with a digit
* Warn about .la files in pkg/PLIST
* Better support for comments in the Makefile
  - fixes the section off by 1 error
    (DISTNAME needs to exist, and so on, when it does)
* don't report "FATAL: no MAINTAINER listed in Makefile" when it does exist
* other random minor bug fixes
2000-03-28 05:44:42 +00:00
Michael Haro
63168faf2f - fix a bug in pkg/* checking
- enforce pkg/COMMENT style
- better info file checking in pkg/PLIST
- don't warn about @unexec rmdir foo || true - the handbook says this is fine
- allow CATEGORIES+=
- warn about www.freebsd.org/~user needing to be people.freebsd.org
- warn about PKGNAME being set from another variable instead of being a
  fatal error
- understand both $(PORTSDIR) and ${PORTSDIR}
2000-03-20 18:03:01 +00:00
Michael Haro
633118fd04 issue a warning when @owner or @group are found in the PLIST 2000-02-02 21:07:39 +00:00
Michael Haro
4922b641a8 add support for @owner and @group in PLIST 2000-01-22 22:06:04 +00:00
Shigeyuki Fukushima
0e2e06a88a Fixes:
- Allow "MAINTAINER?=".
  - Allow "CATEGORIES?=" and "CATEGORIES+=".

PR:		ports/16064
Submitted by:	KIRIYAMA Kazuhiko <kiri@pis.toba-cmt.ac.jp>
2000-01-12 04:48:15 +00:00
Munechika SUMIKAWA
942ecd986a added the following checking:
"in *_DEPENDS, ${PREFIX} must not be used. use ${LOCALBASE}/${X11BASE}
  instead of it."

Commented by:	asami
Reviewed by:	taoka
1999-09-28 16:23:03 +00:00
Satoshi Taoka
2996c814f6 Recently we must use $FreeBSD instead of $Id in Makefile.
So portlint needs this modification.

Approved by: 		maintainer
1999-09-28 02:19:47 +00:00
Peter Wemm
52769fe9fd $Id$ -> $FreeBSD$ 1999-08-29 11:11:15 +00:00
Jun-ichiro itojun Hagino
e25cebf5a9 manpage fix
family name change for itojun (s/Itoh/Hagino/)

Submitted by: "Alexey M. Zelkin" <phantom@cris.net>
1999-08-14 12:55:26 +00:00
Jun-ichiro itojun Hagino
48752d5db8 typo fix
From: "Oleg V. Volkov" <rover@lglobus.ru>
1999-07-24 14:24:46 +00:00
Jun-ichiro itojun Hagino
bd430b955e remove the first comment lines in a section properly. 1999-04-22 05:37:46 +00:00
Jun-ichiro itojun Hagino
f6c89560ba remove pathname for bsd.port.mk.
Reviewed by:	maintainer (myself)
Submitted by:	ben@scientia.demon.co.uk
1999-04-05 03:20:36 +00:00
Steve Price
251772eae4 It seems 'sane' was not mispelled, but was a little confusing. Let's try
'correct' instead.

Submitted by:	asami
1999-04-04 21:35:10 +00:00
Steve Price
c7f658c2ff Fix a spelling nit: sane -> same. 1999-04-02 03:24:13 +00:00
Steve Price
94723819db Handle x11-* categories correctly.
Reviewed by:	maintainer
1999-02-22 03:01:21 +00:00
Jun-ichiro itojun Hagino
b50b1f8d8e remove old ftp site (ftp.foretune.co.jp) from comment. 1999-01-05 12:26:08 +00:00
Jun-ichiro itojun Hagino
f414a317d4 being tired of maintaining portlint only by myself, I decided to
put the source code for "portlint" into FreeBSD port tree.  The
imported revision is 1.65 (in my local RCS file).  (pseudo) version
number for the port is now 2.0.

Whoever make changes to bsd.port.mk is advised to update portlint.pl
too :-)

Note that portlint.pl MUST be portable enough to handle (Net|Open|Free)BSD
bsd.port.mk.  There are people using portlint.pl on non-FreeBSD
platforms.
1999-01-05 12:23:28 +00:00