freebsd-ports/multimedia/qmmp-plugin-pack-qt5/Makefile
Tijl Coosemans 1bf487d3e7 Fix Qt5 symbol version scripts to put the catch-all clause first. When
a symbol matches multiple clauses the last one takes precedence.  If the
catch-all is last it captures everything.  In the case of Qt5 libraries
this caused all symbols to have a Qt_5 label while some should have
Qt_5_PRIVATE_API.  This only affects lld because GNU ld always gives the
catch-all lowest priority.

Older versions of Qt5Webengine exported some memory allocation symbols from
the bundled Chromium.  Version 5.9 stopped exporting these [1] but the
symbols were kept as weak wrappers for the standard allocation functions to
maintain binary compatibility. [2][3]  The problem is that the call to the
standard function in these weak wrappers is only resolved to the standard
function if there's a call to this standard function in other parts of
Qt5Webengine, because only then is there a non-weak symbol that takes
precedence over the weak one.  If there's no such non-weak symbol the call
in the weak wrapper resolves to the weak wrapper itself creating an infinite
call loop that overflows the stack and causes a crash.  Some of the
allocation functions are variants of C++ new and delete and it probably
depends on the compiler whether these variants are used in other parts of
Qt5Webengine.

Remove the weak wrappers (make them Linux specific).  This isn't binary
compatible but we are already breaking that with the changes to the symbol
versions.

[1] 5c2cbfccf9
[2] 2ed5054e3a
[3] 009f5ebb4b

Bump all ports that depend on Qt5.

PR:		234070
Exp-run by:	antoine
Approved by:	kde (adridg)
2019-01-16 11:13:44 +00:00

75 lines
2 KiB
Makefile

# $FreeBSD$
PORTNAME= qmmp-plugin-pack
PORTVERSION= 1.2.0
PORTREVISION= 3
CATEGORIES= multimedia
MASTER_SITES= http://qmmp.ylsoftware.com/files/plugins/ \
SF/qmmp-dev/${PORTNAME}/
PKGNAMESUFFIX= -qt5
MAINTAINER= liangtai.s16@gmail.com
COMMENT= Additional plug-ins for QMMP (Qt5)
LICENSE= GPLv2
LICENSE_FILE= ${WRKSRC}/COPYING
LIB_DEPENDS= libqmmpui.so:multimedia/qmmp-qt5
BUILD_DEPENDS= qmmp-qt5>=1.2.0:multimedia/qmmp-qt5
CONFLICTS= ${PORTNAME}-0.*
PORTSCOUT= limit:^1\..*
USES= cmake pkgconfig qt:5 tar:bzip2
USE_QT= core gui widgets \
buildtools_build linguisttools_build qmake_build
USE_LDCONFIG= yes
OPTIONS_SUB= yes
OPTIONS_MULTI= PLUGINS
OPTIONS_MULTI_PLUGINS= FFAP FFVIDEO GOOM HISTORY MPG123 SRCONV XMP
OPTIONS_DEFAULT= FFAP FFVIDEO GOOM HISTORY MPG123 XMP
OPTIONS_DEFINE_i386= FFAPASM GOOMASM
OPTIONS_DEFAULT_i386= FFAPASM GOOMASM
OPTIONS_DEFINE_amd64= FFAPASM GOOMASM
OPTIONS_DEFAULT_amd64= FFAPASM GOOMASM
FFAP_DESC= Support APE sound file
FFAP_LIB_DEPENDS= libtag.so:audio/taglib
FFAP_CMAKE_BOOL= USE_FFAP
FFAPASM_DESC= Optimize FFap decoder using devel/yasm
FFAPASM_BUILD_DEPENDS= yasm:devel/yasm
FFAPASM_CMAKE_BOOL= USE_ASM
FFVIDEO_DESC= FFmpeg video
FFVIDEO_LIB_DEPENDS= libavcodec.so:multimedia/ffmpeg
FFVIDEO_CMAKE_BOOL= USE_FFVIDEO
GOOM_DESC= Goom spectacle
GOOM_CMAKE_BOOL= USE_GOOM
GOOMASM_DESC= Optimize Goom spectacle using devel/yasm
GOOMASM_BUILD_DEPENDS= yasm:devel/yasm
GOOMASM_CMAKE_BOOL= GOOM_ASM
HISTORY_DESC= Information about listened tracks
HISTORY_USES= qt:5
HISTORY_USE= QT=sql
HISTORY_CMAKE_BOOL= USE_HISTORY
MPG123_LIB_DEPENDS= libmpg123.so:audio/mpg123 \
libtag.so:audio/taglib
MPG123_CMAKE_BOOL= USE_MPG123
SRCONV_DESC= Support the sample rate converter
SRCONV_LIB_DEPENDS= libsamplerate.so:audio/libsamplerate
SRCONV_CMAKE_BOOL= USE_SRC
XMP_DESC= Support various module formats using libxmp
XMP_LIB_DEPENDS= libxmp.so:audio/libxmp
XMP_CMAKE_BOOL= USE_XMP
pre-configure:
@${RM} ${BUILD_WRKSRC}/CMakeCache.txt
.include <bsd.port.mk>