freebsd-ports/net-im/qTox/Makefile
Tijl Coosemans 1bf487d3e7 Fix Qt5 symbol version scripts to put the catch-all clause first. When
a symbol matches multiple clauses the last one takes precedence.  If the
catch-all is last it captures everything.  In the case of Qt5 libraries
this caused all symbols to have a Qt_5 label while some should have
Qt_5_PRIVATE_API.  This only affects lld because GNU ld always gives the
catch-all lowest priority.

Older versions of Qt5Webengine exported some memory allocation symbols from
the bundled Chromium.  Version 5.9 stopped exporting these [1] but the
symbols were kept as weak wrappers for the standard allocation functions to
maintain binary compatibility. [2][3]  The problem is that the call to the
standard function in these weak wrappers is only resolved to the standard
function if there's a call to this standard function in other parts of
Qt5Webengine, because only then is there a non-weak symbol that takes
precedence over the weak one.  If there's no such non-weak symbol the call
in the weak wrapper resolves to the weak wrapper itself creating an infinite
call loop that overflows the stack and causes a crash.  Some of the
allocation functions are variants of C++ new and delete and it probably
depends on the compiler whether these variants are used in other parts of
Qt5Webengine.

Remove the weak wrappers (make them Linux specific).  This isn't binary
compatible but we are already breaking that with the changes to the symbol
versions.

[1] 5c2cbfccf9
[2] 2ed5054e3a
[3] 009f5ebb4b

Bump all ports that depend on Qt5.

PR:		234070
Exp-run by:	antoine
Approved by:	kde (adridg)
2019-01-16 11:13:44 +00:00

76 lines
2.3 KiB
Makefile

# Created by: Yuri Victorovich <yuri@rawbw.com>
# $FreeBSD$
PORTNAME= qTox
DISTVERSIONPREFIX= v
DISTVERSION= 1.16.3
PORTREVISION= 5
CATEGORIES= net-im net-p2p
MAINTAINER= yuri@FreeBSD.org
COMMENT= Qt 5 based Tox client
LICENSE= GPLv3
LICENSE_FILE= ${WRKSRC}/LICENSE
BUILD_DEPENDS= ${LOCALBASE}/include/linux/videodev2.h:multimedia/v4l_compat
LIB_DEPENDS= libavcodec.so:multimedia/ffmpeg \
libexif.so:graphics/libexif \
libfontconfig.so:x11-fonts/fontconfig \
libfreetype.so:print/freetype2 \
libopus.so:audio/opus \
libqrencode.so:graphics/libqrencode \
libsodium.so:security/libsodium \
libsqlcipher.so:databases/sqlcipher \
libtoxcore.so:net-im/tox \
libvpx.so:multimedia/libvpx
USES= cmake compiler:c++11-lib desktop-file-utils gettext gnome openal:soft pkgconfig qt:5
USE_GITHUB= yes
USE_GNOME= gtk20 gdkpixbuf2 cairo
USE_QT= core gui network xml opengl sql sql-sqlite3_run widgets svg \
concurrent_build buildtools_build linguisttools_build qmake_build testlib_build
CMAKE_ARGS= -DGIT_DESCRIBE:STRING=${FULLVERSION}
CMAKE_OFF= USE_CCACHE
OPTIONS_DEFINE= FILTERAUDIO PLATFORM_EXTENSIONS
OPTIONS_DEFAULT= FILTERAUDIO PLATFORM_EXTENSIONS
PLATFORM_EXTENSIONS_DESC= Enable platform specific extensions
FILTERAUDIO_DESC= Enable the echo canceling backend
FILTERAUDIO_CMAKE_BOOL= USE_FILTERAUDIO
FILTERAUDIO_LIB_DEPENDS= libfilteraudio.so:audio/libfilteraudio
PLATFORM_EXTENSIONS_CMAKE_BOOL= PLATFORM_EXTENSIONS
PLATFORM_EXTENSIONS_USE= XORG=x11,xscrnsaver
PLIST_FILES= bin/qtox \
share/applications/io.github.qtox.qTox.desktop \
share/icons/hicolor/scalable/apps/qtox.svgz \
share/metainfo/io.github.qtox.qTox.appdata.xml
.for SZ in 14 16 22 24 32 36 48 64 72 96 128 192 256 512
PLIST_FILES+= share/icons/hicolor/${SZ}x${SZ}/apps/qtox.png
.endfor
.include <bsd.port.pre.mk>
.if ${CHOSEN_COMPILER_TYPE} == "gcc" && ${ARCH} == i386 && !${CFLAGS:M-march=*}
# Needed for __atomic_fetch_add_8
CFLAGS+= -march=i586
.endif
.if !defined(DISTVERSIONSUFFIX)
FULLVERSION= ${PKGVERSION}
.else
FULLVERSION= "${PKGVERSION} (rev.${DISTVERSIONSUFFIX:S/-g//})"
.endif
pre-everything::
@${ECHO_MSG}
@${ECHO_MSG} "Warning: qTox won't build if the option NaCl was selected for Tox!"
@${ECHO_MSG}
pre-configure:
@${REINPLACE_CMD} '/Comment/s,=.*,=${COMMENT},' \
${WRKSRC}/io.github.qtox.qTox.desktop
.include <bsd.port.post.mk>