freebsd-ports/x11/gnomeapplets/files/patch-battery::read-battery.c
Maxim Sobolev 6f15105d69 - Open /dev/apm read-only;
- don't leak file descripton if for fome reasom ioctl(2) on /dev/apm has
  failed.

Submitted by:	Anders Andersson <anders@hack.org> (ro /dev/apm)
		sobomax (descriptor leak)
2002-01-14 18:05:35 +00:00

22 lines
489 B
C

$FreeBSD$
--- battery/read-battery.c 2002/01/14 14:23:46 1.1
+++ battery/read-battery.c 2002/01/14 14:25:45
@@ -170,7 +170,7 @@
*hours_remaining = -1;
*minutes_remaining = 1;
- fd = open(APMDEV, O_RDWR);
+ fd = open(APMDEV, O_RDONLY);
if (fd == -1)
{
g_error (_("Cannot open /dev/apm; can't get data."));
@@ -179,6 +179,7 @@
if (ioctl(fd, APMIO_GETINFO, &aip) == -1) {
g_error(_("ioctl failed on /dev/apm."));
+ close(fd);
return FALSE;
}