freebsd-ports/science/avogadrolibs/Makefile
Tijl Coosemans 1bf487d3e7 Fix Qt5 symbol version scripts to put the catch-all clause first. When
a symbol matches multiple clauses the last one takes precedence.  If the
catch-all is last it captures everything.  In the case of Qt5 libraries
this caused all symbols to have a Qt_5 label while some should have
Qt_5_PRIVATE_API.  This only affects lld because GNU ld always gives the
catch-all lowest priority.

Older versions of Qt5Webengine exported some memory allocation symbols from
the bundled Chromium.  Version 5.9 stopped exporting these [1] but the
symbols were kept as weak wrappers for the standard allocation functions to
maintain binary compatibility. [2][3]  The problem is that the call to the
standard function in these weak wrappers is only resolved to the standard
function if there's a call to this standard function in other parts of
Qt5Webengine, because only then is there a non-weak symbol that takes
precedence over the weak one.  If there's no such non-weak symbol the call
in the weak wrapper resolves to the weak wrapper itself creating an infinite
call loop that overflows the stack and causes a crash.  Some of the
allocation functions are variants of C++ new and delete and it probably
depends on the compiler whether these variants are used in other parts of
Qt5Webengine.

Remove the weak wrappers (make them Linux specific).  This isn't binary
compatible but we are already breaking that with the changes to the symbol
versions.

[1] 5c2cbfccf9
[2] 2ed5054e3a
[3] 009f5ebb4b

Bump all ports that depend on Qt5.

PR:		234070
Exp-run by:	antoine
Approved by:	kde (adridg)
2019-01-16 11:13:44 +00:00

71 lines
2 KiB
Makefile

# $FreeBSD$
PORTNAME= avogadrolibs
DISTVERSION= 1.92.0
PORTREVISION= 4
CATEGORIES= science
PATCH_SITES= https://github.com/${GH_ACCOUNT}/${PORTNAME}/commit/
PATCHFILES= cf9d82575796d5fcabb153bdebde26843d81d83e.patch:-p1 \
ea813f683cdd9865994c0ba94a24325e04b9f8fb.patch:-p1 \
MAINTAINER= yuri@FreeBSD.org
COMMENT= Avogadro2 libraries for chemical editor and visualization applications
LICENSE= GPLv2
LICENSE_FILE= ${WRKSRC}/LICENSE
BUILD_DEPENDS= ${LOCALBASE}/include/mmtf.hpp:science/mmtf
USES= cmake compiler:c++11-lang eigen:3,build,run # eigen needs to be 'run' because it is written into cmake files
USE_GITHUB= yes
GH_ACCOUNT= OpenChemistry
USE_LDCONFIG= yes
CMAKE_ON= BUILD_SHARED_LIBS
OPTIONS_DEFINE= HDF5 LIBARCHIVE LIBMSYM MOLEQUEUE OPENGL QT5 SPGLIB VTK
OPTIONS_DEFAULT= LIBARCHIVE LIBMSYM MOLEQUEUE OPENGL QT5 SPGLIB
OPTIONS_SUB= yes
HDF5_CMAKE_BOOL= USE_HDF5
HDF5_LIB_DEPENDS= libhdf5.so:science/hdf5 \
libsz.so:science/szip
LIBARCHIVE_DESC= Enable optional Libarchive features
LIBARCHIVE_CMAKE_BOOL= USE_LIBARCHIVE
LIBARCHIVE_USES= libarchive
LIBARCHIVE_IMPLIES= QT5
LIBMSYM_DESC= Enable optional features using libmsym
LIBMSYM_CMAKE_BOOL= USE_LIBMSYM
LIBMSYM_LIB_DEPENDS= libmsym.so:science/libmsym
MOLEQUEUE_DESC= Enable the MoleQueue dependent functionality
MOLEQUEUE_CMAKE_BOOL= USE_MOLEQUEUE
MOLEQUEUE_LIB_DEPENDS= libMoleQueueClient.so:misc/molequeue
MOLEQUEUE_IMPLIES= QT5
OPENGL_CMAKE_BOOL= USE_OPENGL
OPENGL_USES= gl
OPENGL_USE= GL=gl,glew,glu
QT5_CMAKE_BOOL= USE_QT
QT5_USES= qt:5
QT5_USE= QT=core,concurrent,gui,network,widgets,buildtools_build,qmake_build
QT5_IMPLIES= OPENGL
SPGLIB_DESC= Enable optional features using spglib
SPGLIB_CMAKE_BOOL= USE_SPGLIB
SPGLIB_LIB_DEPENDS= libsymspg.so:science/spglib
VTK_DESC= Enable libraries that use VTK
VTK_CMAKE_BOOL= USE_VTK
VTK_LIB_DEPENDS= libvtksys-8.1.so.1:math/vtk8
VTK_IMPLIES= QT5
VTK_BROKEN= Needs https://github.com/psavery/genXrdPattern, etc
post-install:
@${RM} -r ${STAGEDIR}${PREFIX}/share/doc
.include <bsd.port.mk>