a symbol matches multiple clauses the last one takes precedence. If the catch-all is last it captures everything. In the case of Qt5 libraries this caused all symbols to have a Qt_5 label while some should have Qt_5_PRIVATE_API. This only affects lld because GNU ld always gives the catch-all lowest priority. Older versions of Qt5Webengine exported some memory allocation symbols from the bundled Chromium. Version 5.9 stopped exporting these [1] but the symbols were kept as weak wrappers for the standard allocation functions to maintain binary compatibility. [2][3] The problem is that the call to the standard function in these weak wrappers is only resolved to the standard function if there's a call to this standard function in other parts of Qt5Webengine, because only then is there a non-weak symbol that takes precedence over the weak one. If there's no such non-weak symbol the call in the weak wrapper resolves to the weak wrapper itself creating an infinite call loop that overflows the stack and causes a crash. Some of the allocation functions are variants of C++ new and delete and it probably depends on the compiler whether these variants are used in other parts of Qt5Webengine. Remove the weak wrappers (make them Linux specific). This isn't binary compatible but we are already breaking that with the changes to the symbol versions. [1]5c2cbfccf9
[2]2ed5054e3a
[3]009f5ebb4b
Bump all ports that depend on Qt5. PR: 234070 Exp-run by: antoine Approved by: kde (adridg)
62 lines
1.9 KiB
Makefile
62 lines
1.9 KiB
Makefile
# Created by: Yinghong Liu <relaxbsd@gmail.com>
|
|
# $FreeBSD$
|
|
|
|
PORTNAME= luminance-hdr
|
|
DISTVERSION= 2.4.0
|
|
PORTREVISION= 27
|
|
CATEGORIES= graphics
|
|
MASTER_SITES= SF/qtpfsgui/luminance/${DISTVERSION}
|
|
PKGNAMESUFFIX= -qt5
|
|
|
|
MAINTAINER= h2+fbsdports@fsfe.org
|
|
COMMENT= Complete open source solution for HDR photography
|
|
|
|
LICENSE= GPLv2
|
|
|
|
BUILD_DEPENDS= ${LOCALBASE}/include/fftw3.h:math/fftw3
|
|
LIB_DEPENDS= libfftw3f.so:math/fftw3-float \
|
|
libexiv2.so:graphics/exiv2 \
|
|
libIlmImf.so:graphics/openexr \
|
|
libtiff.so:graphics/tiff \
|
|
libgsl.so:math/gsl \
|
|
libraw_r.so:graphics/libraw \
|
|
libboost_system.so:devel/boost-libs
|
|
|
|
USES= cmake jpeg pkgconfig qt:5 tar:bzip2
|
|
USE_QT= concurrent gui printsupport sql webkit xml \
|
|
buildtools_build linguist_build qmake_build \
|
|
imageformats_run
|
|
INSTALLS_ICONS= yes
|
|
|
|
MAKE_JOBS_UNSAFE=yes
|
|
|
|
CONFLICTS_INSTALL= luminance-hdr-[0-9]*
|
|
|
|
OPTIONS_DEFINE= DOCS
|
|
|
|
post-patch:
|
|
# Remove the non-required dependency on Qt5 Declarative. This can be dropped
|
|
# once www/qt5-webengine lands in the portstree and this port can be updated to
|
|
# a version >= 2.5.0.
|
|
@${REINPLACE_CMD} -e '/Qt5Declarative/d' \
|
|
${WRKSRC}/CMakeLists.txt
|
|
# Do not install yet another copy of GPL (we use license framework instead)
|
|
# and fix installation path for docs (but not for internal help files)
|
|
@${REINPLACE_CMD} -e '/LICENSE/d ; \
|
|
/#info files/s,share/luminance-hdr,${DOCSDIR_REL},' \
|
|
${WRKSRC}/CMakeLists.txt
|
|
# Point to the right location for program where to look for GPL text
|
|
@${REINPLACE_CMD} -e 's,LICENSE,${LICENSE}, ; \
|
|
s,share/doc/luminance-hdr,share/licenses/${PKGNAME},' \
|
|
${WRKSRC}/src/UI/UMessageBox.cpp
|
|
|
|
# Allow builds from release distfile to display correct git hash in "About"
|
|
# dialog window
|
|
@${REINPLACE_CMD} -e \
|
|
's,@GIT_SHA1@,be5409f2ed028b0a509d3f4cd44a970a09d2ef6c,' \
|
|
${WRKSRC}/src/Common/GitSHA1.cpp.in
|
|
|
|
pre-install:
|
|
QT_BINDIR_REL=bin
|
|
|
|
.include <bsd.port.mk>
|