freebsd-ports/science/kst2/Makefile
Tijl Coosemans 1bf487d3e7 Fix Qt5 symbol version scripts to put the catch-all clause first. When
a symbol matches multiple clauses the last one takes precedence.  If the
catch-all is last it captures everything.  In the case of Qt5 libraries
this caused all symbols to have a Qt_5 label while some should have
Qt_5_PRIVATE_API.  This only affects lld because GNU ld always gives the
catch-all lowest priority.

Older versions of Qt5Webengine exported some memory allocation symbols from
the bundled Chromium.  Version 5.9 stopped exporting these [1] but the
symbols were kept as weak wrappers for the standard allocation functions to
maintain binary compatibility. [2][3]  The problem is that the call to the
standard function in these weak wrappers is only resolved to the standard
function if there's a call to this standard function in other parts of
Qt5Webengine, because only then is there a non-weak symbol that takes
precedence over the weak one.  If there's no such non-weak symbol the call
in the weak wrapper resolves to the weak wrapper itself creating an infinite
call loop that overflows the stack and causes a crash.  Some of the
allocation functions are variants of C++ new and delete and it probably
depends on the compiler whether these variants are used in other parts of
Qt5Webengine.

Remove the weak wrappers (make them Linux specific).  This isn't binary
compatible but we are already breaking that with the changes to the symbol
versions.

[1] 5c2cbfccf9
[2] 2ed5054e3a
[3] 009f5ebb4b

Bump all ports that depend on Qt5.

PR:		234070
Exp-run by:	antoine
Approved by:	kde (adridg)
2019-01-16 11:13:44 +00:00

77 lines
2 KiB
Makefile

# Created by: Markus Brueffer <markus@FreeBSD.org>
# $FreeBSD$
PORTNAME= kst
DISTVERSION= ${KST_VERSION}.${KST_DATE}
PORTREVISION= 2
CATEGORIES= science kde
MAINTAINER= makc@FreeBSD.org
COMMENT= Data viewing and plotting tool
LICENSE= GPLv2 GFDL LGPL20
LICENSE_COMB= multi
LICENSE_FILE_GPLv2= ${WRKSRC}/COPYING
LICENSE_FILE_GFDL= ${WRKSRC}/COPYING-DOCS
LICENSE_FILE_LGPL20= ${WRKSRC}/COPYING.LGPL
LIB_DEPENDS= libgsl.so:math/gsl \
libtiff.so:graphics/tiff
KST_VERSION= 2.0.8
KST_DATE= 20181123
USES= cmake desktop-file-utils pkgconfig \
shared-mime-info
_USE_QT4= corelib gui xml designer network svg linguisttools_build \
qmake_build moc_build rcc_build uic_build
_USE_QT5= concurrent core gui network printsupport svg widgets xml \
buildtools_build linguisttools_build qmake_build
USE_LDCONFIG= yes
USE_GITHUB= yes
GH_ACCOUNT= Kst-plot
GH_TAGNAME= c5dddb1
CMAKE_ARGS= -Dkst_install_prefix=${PREFIX} \
-Dkst_pch=off \
-Dkst_version_string=${KST_VERSION} \
-Dkst_revision=${KST_DATE} \
-DCMAKE_DISABLE_FIND_PACKAGE_Getdata=ON
PLIST_SUB= SHLIB_VER=${KST_VERSION}
OPTIONS_DEFINE= FITS MATLAB NETCDF
OPTIONS_SINGLE= TOOLKIT
OPTIONS_SINGLE_TOOLKIT= QT4 QT5
OPTIONS_DEFAULT= QT5
OPTIONS_SUB= yes
FITS_DESC= Support for data in FITS format
FITS_LIB_DEPENDS= libcfitsio.so:astro/cfitsio
FITS_CMAKE_OFF= -DCMAKE_DISABLE_FIND_PACKAGE_CFITSIO=ON
MATLAB_DESC= Support for data in MATLAB format
MATLAB_LIB_DEPENDS= libmatio.so:math/matio
MATLAB_CMAKE_OFF= -DCMAKE_DISABLE_FIND_PACKAGE_Matio=ON
NETCDF_DESC= Support for data in NetCDF format (broken)
NETCDF_LIB_DEPENDS= libnetcdf.so:science/netcdf
NETCDF_IGNORE= does not support NetCDF 4
NETCDF_CMAKE_OFF= -DCMAKE_DISABLE_FIND_PACKAGE_Netcdf=ON
TOOLKIT_DESC= Qt toolkit
QT4_USES= qt:4
QT4_USE= ${_USE_QT4:S/^/QT=/}
QT5_USES= compiler:c++11-lang qt:5
QT5_USE= ${_USE_QT5:S/^/QT=/}
QT5_CMAKE_ON= -Dkst_qt5=on
.include <bsd.port.options.mk>
.if ${PORT_OPTIONS:MQT4}
DEPRECATED= Qt4 has been EOL since december 2015
EXPIRATION_DATE= 2019-03-15
.endif
.include <bsd.port.mk>