freebsd-ports/multimedia/smtube/Makefile
Tijl Coosemans 1bf487d3e7 Fix Qt5 symbol version scripts to put the catch-all clause first. When
a symbol matches multiple clauses the last one takes precedence.  If the
catch-all is last it captures everything.  In the case of Qt5 libraries
this caused all symbols to have a Qt_5 label while some should have
Qt_5_PRIVATE_API.  This only affects lld because GNU ld always gives the
catch-all lowest priority.

Older versions of Qt5Webengine exported some memory allocation symbols from
the bundled Chromium.  Version 5.9 stopped exporting these [1] but the
symbols were kept as weak wrappers for the standard allocation functions to
maintain binary compatibility. [2][3]  The problem is that the call to the
standard function in these weak wrappers is only resolved to the standard
function if there's a call to this standard function in other parts of
Qt5Webengine, because only then is there a non-weak symbol that takes
precedence over the weak one.  If there's no such non-weak symbol the call
in the weak wrapper resolves to the weak wrapper itself creating an infinite
call loop that overflows the stack and causes a crash.  Some of the
allocation functions are variants of C++ new and delete and it probably
depends on the compiler whether these variants are used in other parts of
Qt5Webengine.

Remove the weak wrappers (make them Linux specific).  This isn't binary
compatible but we are already breaking that with the changes to the symbol
versions.

[1] 5c2cbfccf9
[2] 2ed5054e3a
[3] 009f5ebb4b

Bump all ports that depend on Qt5.

PR:		234070
Exp-run by:	antoine
Approved by:	kde (adridg)
2019-01-16 11:13:44 +00:00

66 lines
1.7 KiB
Makefile

# Created by: Pawel Pekala <pawel@FreeBSD.org>
# $FreeBSD$
PORTNAME= smtube
PORTVERSION= 18.9.0
PORTREVISION= 2
CATEGORIES= multimedia
MASTER_SITES= SF/smtube/SMTube/${PORTVERSION}/
MAINTAINER= kikadf.01@gmail.com
COMMENT= SMPlayer YouTube browser
LICENSE= GPLv2
LICENSE_FILE= ${WRKSRC}/Copying.txt
USES= gmake tar:bzip2
ALL_TARGET= #empty
MAKE_ARGS= DATA_PATH="${DATADIR}" DOC_PATH="${DOCSDIR}" \
LRELEASE="${LRELEASE}" MAKE="${MAKE_CMD}" \
QMAKE="${QMAKE}"
PORTDOCS= *
OPTIONS_SINGLE= TOOLKIT
OPTIONS_SINGLE_TOOLKIT= QT4 QT5
OPTIONS_MULTI= PLAYER
OPTIONS_MULTI_PLAYER= MPLAYER MPV SMPLAYER VLC
OPTIONS_DEFINE= DOCS
OPTIONS_DEFAULT= QT5 SMPLAYER
TOOLKIT_DESC= Qt toolkit version
PLAYER_DESC= Video player
MPLAYER_DESC= MPlayer dependency for video playback
MPV_DESC= mpv dependency for video playback
SMPLAYER_DESC= SMPlayer dependency for video playback
VLC_DESC= VLC dependency for video playback
QT4_USES= qt:4
QT4_USE= qt=qmake_build,moc_build,rcc_build,uic_build
QT4_USE+= qt=corelib,network,script,gui,webkit,linguisttools_build
QT5_USES= gl qt:5
QT5_USE= qt=qmake_build,buildtools_build,linguisttools_build
QT5_USE+= qt=core,network,script,gui,webkit,widgets gl=gl
MPLAYER_RUN_DEPENDS= mplayer:multimedia/mplayer
MPV_RUN_DEPENDS= mpv:multimedia/mpv
SMPLAYER_RUN_DEPENDS= smplayer:multimedia/smplayer
VLC_RUN_DEPENDS= vlc:multimedia/vlc
.include <bsd.port.options.mk>
.if ${PORT_OPTIONS:MQT4}
DEPRECATED= Qt4 has been EOL since december 2015
EXPIRATION_DATE= 2019-03-15
.endif
post-patch:
@${REINPLACE_CMD} 's|$$(QMAKE_OPTS)|${QMAKE_ARGS:S,\$,\$\$,g}|' \
${WRKSRC}/Makefile
post-install:
@${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/${PORTNAME}
.include <bsd.port.mk>