kpriv/linux-hardened
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

ppp: reuse print_hex_dump_bytes

Browse source 
There is a native function to dump hex buffers.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Andy Shevchenko 2013-03-27 05:54:14 +00:00 committed by David S. Miller
parent 5a048e3b59
commit 167bfa7184
1 changed files with 2 additions and 51 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

53
drivers/net/ppp/ppp_synctty.c
View file

@ -105,64 +105,15 @@ static const struct ppp_channel_ops sync_ops = {
}; };
/* /*
* Utility procedures to print a buffer in hex/ascii * Utility procedure to print a buffer in hex/ascii
*/ */
static void
ppp_print_hex (register __u8 * out, const __u8 * in, int count)
{
register __u8 next_ch;
static const char hex[] = "0123456789ABCDEF";
while (count-- > 0) {
next_ch = *in++;
*out++ = hex[(next_ch >> 4) & 0x0F];
*out++ = hex[next_ch & 0x0F];
++out;
}
}
static void
ppp_print_char (register __u8 * out, const __u8 * in, int count)
{
register __u8 next_ch;
while (count-- > 0) {
next_ch = *in++;
if (next_ch < 0x20 || next_ch > 0x7e)
*out++ = '.';
else {
*out++ = next_ch;
if (next_ch == '%') /* printk/syslogd has a bug !! */
*out++ = '%';
}
}
*out = '\0';
}
static void static void
ppp_print_buffer (const char *name, const __u8 *buf, int count) ppp_print_buffer (const char *name, const __u8 *buf, int count)
{ {
__u8 line[44];
if (name != NULL) if (name != NULL)
printk(KERN_DEBUG "ppp_synctty: %s, count = %d\n", name, count); printk(KERN_DEBUG "ppp_synctty: %s, count = %d\n", name, count);
while (count > 8) { print_hex_dump_bytes("", DUMP_PREFIX_NONE, buf, count);
memset (line, 32, 44);
ppp_print_hex (line, buf, 8);
ppp_print_char (&line[8 * 3], buf, 8);
printk(KERN_DEBUG "%s\n", line);
count -= 8;
buf += 8;
}
if (count > 0) {
memset (line, 32, 44);
ppp_print_hex (line, buf, count);
ppp_print_char (&line[8 * 3], buf, count);
printk(KERN_DEBUG "%s\n", line);
}
} }