kpriv/linux-hardened
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

i2c-sis5595: Minor cleanups in sis5595_access

Browse source 
* Remove commented-out code.
* Use dev_warn instead of printk.
* Remove a legacy comment.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
This commit is contained in:
Jean Delvare 2008-04-29 23:11:38 +02:00 committed by Jean Delvare
parent 3578a0759e
commit 1842cc2eeb
1 changed files with 2 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
drivers/i2c/busses/i2c-sis5595.c
View file

@ -316,14 +316,8 @@ static s32 sis5595_access(struct i2c_adapter *adap, u16 addr,
} }
size = (size == I2C_SMBUS_PROC_CALL) ? SIS5595_PROC_CALL : SIS5595_WORD_DATA; size = (size == I2C_SMBUS_PROC_CALL) ? SIS5595_PROC_CALL : SIS5595_WORD_DATA;
break; break;
/*
case I2C_SMBUS_BLOCK_DATA:
printk(KERN_WARNING "sis5595.o: Block data not yet implemented!\n");
return -1;
break;
*/
default: default:
printk(KERN_WARNING "sis5595.o: Unsupported transaction %d\n", size); dev_warn(&adap->dev, "Unsupported transaction %d\n", size);
return -1; return -1;
} }
@ -338,9 +332,7 @@ static s32 sis5595_access(struct i2c_adapter *adap, u16 addr,
switch (size) { switch (size) {
case SIS5595_BYTE: /* Where is the result put? I assume here it is in case SIS5595_BYTE:
SMB_DATA but it might just as well be in the
SMB_CMD. No clue in the docs */
case SIS5595_BYTE_DATA: case SIS5595_BYTE_DATA:
data->byte = sis5595_read(SMB_BYTE); data->byte = sis5595_read(SMB_BYTE);
break; break;