Btrfs: be smarter about dropping things from the tree log
When we truncate existing items in the tree log we've been searching for each individual item and removing them. This is unnecessary churn and searching, just keep track of the slot we are on and how many items we need to delete and delete them all at once. Thanks, Signed-off-by: Josef Bacik <jbacik@fusionio.com>
This commit is contained in:
parent
6f1fed7753
commit
18ec90d63f
1 changed files with 13 additions and 2 deletions
|
@ -2901,6 +2901,7 @@ static int drop_objectid_items(struct btrfs_trans_handle *trans,
|
||||||
int ret;
|
int ret;
|
||||||
struct btrfs_key key;
|
struct btrfs_key key;
|
||||||
struct btrfs_key found_key;
|
struct btrfs_key found_key;
|
||||||
|
int start_slot;
|
||||||
|
|
||||||
key.objectid = objectid;
|
key.objectid = objectid;
|
||||||
key.type = max_key_type;
|
key.type = max_key_type;
|
||||||
|
@ -2922,8 +2923,18 @@ static int drop_objectid_items(struct btrfs_trans_handle *trans,
|
||||||
if (found_key.objectid != objectid)
|
if (found_key.objectid != objectid)
|
||||||
break;
|
break;
|
||||||
|
|
||||||
ret = btrfs_del_item(trans, log, path);
|
found_key.offset = 0;
|
||||||
if (ret)
|
found_key.type = 0;
|
||||||
|
ret = btrfs_bin_search(path->nodes[0], &found_key, 0,
|
||||||
|
&start_slot);
|
||||||
|
|
||||||
|
ret = btrfs_del_items(trans, log, path, start_slot,
|
||||||
|
path->slots[0] - start_slot + 1);
|
||||||
|
/*
|
||||||
|
* If start slot isn't 0 then we don't need to re-search, we've
|
||||||
|
* found the last guy with the objectid in this tree.
|
||||||
|
*/
|
||||||
|
if (ret || start_slot != 0)
|
||||||
break;
|
break;
|
||||||
btrfs_release_path(path);
|
btrfs_release_path(path);
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in a new issue