kpriv/linux-hardened
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

dma-debug: release free_entries_lock before saving stack trace

Browse source 
Saving stack trace can take a while and once the entry
is allocated free_entries_lock is no longer needed.

Signed-off-by: Jakub Kicinski <kubakici@wp.pl>
Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
This commit is contained in:
Jakub Kicinski 2012-04-04 03:19:10 +02:00 committed by Joerg Roedel
parent 0034102808
commit 29cdd4e4ec
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
lib/dma-debug.c
View file

@ -430,7 +430,7 @@ static struct dma_debug_entry *__dma_entry_alloc(void)
*/ */
static struct dma_debug_entry *dma_entry_alloc(void) static struct dma_debug_entry *dma_entry_alloc(void)
{ {
struct dma_debug_entry *entry = NULL; struct dma_debug_entry *entry;
unsigned long flags; unsigned long flags;
spin_lock_irqsave(&free_entries_lock, flags); spin_lock_irqsave(&free_entries_lock, flags);
@ -438,11 +438,14 @@ static struct dma_debug_entry *dma_entry_alloc(void)
if (list_empty(&free_entries)) { if (list_empty(&free_entries)) {
pr_err("DMA-API: debugging out of memory - disabling\n"); pr_err("DMA-API: debugging out of memory - disabling\n");
global_disable = true; global_disable = true;
goto out; spin_unlock_irqrestore(&free_entries_lock, flags);
return NULL;
} }
entry = __dma_entry_alloc(); entry = __dma_entry_alloc();
spin_unlock_irqrestore(&free_entries_lock, flags);
#ifdef CONFIG_STACKTRACE #ifdef CONFIG_STACKTRACE
entry->stacktrace.max_entries = DMA_DEBUG_STACKTRACE_ENTRIES; entry->stacktrace.max_entries = DMA_DEBUG_STACKTRACE_ENTRIES;
entry->stacktrace.entries = entry->st_entries; entry->stacktrace.entries = entry->st_entries;
@ -450,9 +453,6 @@ static struct dma_debug_entry *dma_entry_alloc(void)
save_stack_trace(&entry->stacktrace); save_stack_trace(&entry->stacktrace);
#endif #endif
out:
spin_unlock_irqrestore(&free_entries_lock, flags);
return entry; return entry;
} }