kpriv/linux-hardened
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

thunderbolt: Use kcalloc

Browse source 
The advantage of kcalloc is, that will prevent integer overflows
which could result from the multiplication of number of elements
and size and it is also a bit nicer to read.

Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Acked-by: Andreas Noever <andreas.noever@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Himangi Saraogi 2014-07-12 01:12:43 +05:30 committed by Greg Kroah-Hartman
parent 95b4ecbf75
commit 2a211f320e
1 changed files with 4 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
drivers/thunderbolt/nhi.c
View file

@ -569,12 +569,10 @@ static int nhi_probe(struct pci_dev *pdev, const struct pci_device_id *id)
nhi->hop_count); nhi->hop_count);
INIT_WORK(&nhi->interrupt_work, nhi_interrupt_work); INIT_WORK(&nhi->interrupt_work, nhi_interrupt_work);
nhi->tx_rings = devm_kzalloc(&pdev->dev, nhi->tx_rings = devm_kcalloc(&pdev->dev, nhi->hop_count,
nhi->hop_count * sizeof(*nhi->tx_rings), sizeof(*nhi->tx_rings), GFP_KERNEL);
GFP_KERNEL); nhi->rx_rings = devm_kcalloc(&pdev->dev, nhi->hop_count,
nhi->rx_rings = devm_kzalloc(&pdev->dev, sizeof(*nhi->rx_rings), GFP_KERNEL);
nhi->hop_count * sizeof(*nhi->rx_rings),
GFP_KERNEL);
if (!nhi->tx_rings || !nhi->rx_rings) if (!nhi->tx_rings || !nhi->rx_rings)
return -ENOMEM; return -ENOMEM;