kpriv/linux-hardened
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

[CCID3]: Remove redundant `len' test

Browse source 
Since CCID3 avoids  sending 0-byte data packets (cf. ccid3_hc_tx_send_packet),
testing for zero-payload length, as performed by ccid3_hc_tx_update_s, is
redundant - hence removed by this patch.

Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Acked-by: Ian McDonald <ian.mcdonald@jandi.co.nz>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Gerrit Renker 2007-03-20 13:10:15 -03:00 committed by David S. Miller
parent 8d13bf9a0b
commit 353b13e10a
1 changed files with 2 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
net/dccp/ccids/ccid3.c
View file

@ -149,11 +149,8 @@ static void ccid3_hc_tx_update_x(struct sock *sk, struct timeval *now)
*/ */
static inline void ccid3_hc_tx_update_s(struct ccid3_hc_tx_sock *hctx, int len) static inline void ccid3_hc_tx_update_s(struct ccid3_hc_tx_sock *hctx, int len)
{ {
if (unlikely(len == 0)) hctx->ccid3hctx_s = hctx->ccid3hctx_s == 0 ? len :
ccid3_pr_debug("Packet payload length is 0 - not updating\n"); (9 * hctx->ccid3hctx_s + len) / 10;
else
hctx->ccid3hctx_s = hctx->ccid3hctx_s == 0 ? len :
(9 * hctx->ccid3hctx_s + len) / 10;
/* /*
* Note: We could do a potential optimisation here - when `s' changes, * Note: We could do a potential optimisation here - when `s' changes,
* recalculate sending rate and consequently t_ipi, t_delta, and * recalculate sending rate and consequently t_ipi, t_delta, and