kpriv/linux-hardened
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

usb: dwc3: exynos: change goto labels to meaningful names

Browse source 
Change goto labels to meaningful names from a series of errNs.

Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
This commit is contained in:
Shuah Khan 2017-01-30 12:25:04 -07:00 committed by Felipe Balbi
parent f3bcfc7e68
commit 3a932b0f50
1 changed files with 11 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
drivers/usb/dwc3/dwc3-exynos.c
View file

@ -147,53 +147,53 @@ static int dwc3_exynos_probe(struct platform_device *pdev)
exynos->vdd33 = devm_regulator_get(dev, "vdd33"); exynos->vdd33 = devm_regulator_get(dev, "vdd33");
if (IS_ERR(exynos->vdd33)) { if (IS_ERR(exynos->vdd33)) {
ret = PTR_ERR(exynos->vdd33); ret = PTR_ERR(exynos->vdd33);
goto err2; goto vdd33_err;
} }
ret = regulator_enable(exynos->vdd33); ret = regulator_enable(exynos->vdd33);
if (ret) { if (ret) {
dev_err(dev, "Failed to enable VDD33 supply\n"); dev_err(dev, "Failed to enable VDD33 supply\n");
goto err2; goto vdd33_err;
} }
exynos->vdd10 = devm_regulator_get(dev, "vdd10"); exynos->vdd10 = devm_regulator_get(dev, "vdd10");
if (IS_ERR(exynos->vdd10)) { if (IS_ERR(exynos->vdd10)) {
ret = PTR_ERR(exynos->vdd10); ret = PTR_ERR(exynos->vdd10);
goto err3; goto vdd10_err;
} }
ret = regulator_enable(exynos->vdd10); ret = regulator_enable(exynos->vdd10);
if (ret) { if (ret) {
dev_err(dev, "Failed to enable VDD10 supply\n"); dev_err(dev, "Failed to enable VDD10 supply\n");
goto err3; goto vdd10_err;
} }
ret = dwc3_exynos_register_phys(exynos); ret = dwc3_exynos_register_phys(exynos);
if (ret) { if (ret) {
dev_err(dev, "couldn't register PHYs\n"); dev_err(dev, "couldn't register PHYs\n");
goto err4; goto phys_err;
} }
if (node) { if (node) {
ret = of_platform_populate(node, NULL, NULL, dev); ret = of_platform_populate(node, NULL, NULL, dev);
if (ret) { if (ret) {
dev_err(dev, "failed to add dwc3 core\n"); dev_err(dev, "failed to add dwc3 core\n");
goto err5; goto populate_err;
} }
} else { } else {
dev_err(dev, "no device node, failed to add dwc3 core\n"); dev_err(dev, "no device node, failed to add dwc3 core\n");
ret = -ENODEV; ret = -ENODEV;
goto err5; goto populate_err;
} }
return 0; return 0;
err5: populate_err:
platform_device_unregister(exynos->usb2_phy); platform_device_unregister(exynos->usb2_phy);
platform_device_unregister(exynos->usb3_phy); platform_device_unregister(exynos->usb3_phy);
err4: phys_err:
regulator_disable(exynos->vdd10); regulator_disable(exynos->vdd10);
err3: vdd10_err:
regulator_disable(exynos->vdd33); regulator_disable(exynos->vdd33);
err2: vdd33_err:
clk_disable_unprepare(exynos->axius_clk); clk_disable_unprepare(exynos->axius_clk);
axius_clk_err: axius_clk_err:
clk_disable_unprepare(exynos->susp_clk); clk_disable_unprepare(exynos->susp_clk);