kpriv/linux-hardened
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

serial_8250: pci_enable_device fail is not fully handled

Browse source 
<rmk> talking about leaks - I noticed that the 'check return of
pci_enable_dev()' in the 8250 pci resume function finally made it in
despite my objections against it (causing stuff in higher levels to
leak).

Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Alan Cox 2008-10-13 10:36:11 +01:00 committed by Linus Torvalds
parent 43b11d33f2
commit 40836c484c
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/serial/8250_pci.c
View file

@ -2041,9 +2041,9 @@ static int pciserial_resume_one(struct pci_dev *dev)
* The device may have been disabled. Re-enable it. * The device may have been disabled. Re-enable it.
*/ */
err = pci_enable_device(dev); err = pci_enable_device(dev);
/* FIXME: We cannot simply error out here */
if (err) if (err)
return err; printk(KERN_ERR "pciserial: Unable to re-enable ports, trying to continue.\n");
pciserial_resume_ports(priv); pciserial_resume_ports(priv);
} }
return 0; return 0;