kpriv/linux-hardened
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

crypto: LLVMLinux: Remove VLAIS usage from crypto/testmgr.c

Browse source 
Replaced the use of a Variable Length Array In Struct (VLAIS) with a C99
compliant equivalent. This patch allocates the appropriate amount of memory
using a char array using the SHASH_DESC_ON_STACK macro.

The new code can be compiled with both gcc and clang.

Signed-off-by: Jan-Simon Möller <dl9pf@gmx.de>
Signed-off-by: Behan Webster <behanw@converseincode.com>
Reviewed-by: Mark Charlebois <charlebm@gmail.com>
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Cc: pageexec@freemail.hu
This commit is contained in:
Jan-Simon Möller 2012-07-02 13:48:30 +02:00 committed by Behan Webster
parent 357aabed62
commit 4c5c302494
1 changed files with 6 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
crypto/testmgr.c
View file

@ -1678,16 +1678,14 @@ static int alg_test_crc32c(const struct alg_test_desc *desc,
} }
do { do {
struct { SHASH_DESC_ON_STACK(shash, tfm);
struct shash_desc shash; u32 *ctx = (u32 *)shash_desc_ctx(shash);
char ctx[crypto_shash_descsize(tfm)];
} sdesc;
sdesc.shash.tfm = tfm; shash->tfm = tfm;
sdesc.shash.flags = 0; shash->flags = 0;
*(u32 *)sdesc.ctx = le32_to_cpu(420553207); *ctx = le32_to_cpu(420553207);
err = crypto_shash_final(&sdesc.shash, (u8 *)&val); err = crypto_shash_final(shash, (u8 *)&val);
if (err) { if (err) {
printk(KERN_ERR "alg: crc32c: Operation failed for " printk(KERN_ERR "alg: crc32c: Operation failed for "
"%s: %d\n", driver, err); "%s: %d\n", driver, err);