kpriv/linux-hardened
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

sched: domain sysctl fixes: use kcalloc()

Browse source 
kcalloc checks for n * sizeof(element) overflows and it zeros.

Signed-off-by: Milton Miller <miltonm@bga.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
This commit is contained in:
Milton Miller 2007-10-15 17:00:19 +02:00 committed by Ingo Molnar
parent 0dbee3a6b0
commit 5cf9f062c8
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
kernel/sched.c
View file

@ -5243,10 +5243,9 @@ static struct ctl_table sd_ctl_root[] = {
static struct ctl_table *sd_alloc_ctl_entry(int n) static struct ctl_table *sd_alloc_ctl_entry(int n)
{ {
struct ctl_table *entry = struct ctl_table *entry =
kmalloc(n * sizeof(struct ctl_table), GFP_KERNEL); kcalloc(n, sizeof(struct ctl_table), GFP_KERNEL);
BUG_ON(!entry); BUG_ON(!entry);
memset(entry, 0, n * sizeof(struct ctl_table));
return entry; return entry;
} }
@ -6018,7 +6017,7 @@ static int build_sched_domains(const cpumask_t *cpu_map)
/* /*
* Allocate the per-node list of sched groups * Allocate the per-node list of sched groups
*/ */
sched_group_nodes = kzalloc(sizeof(struct sched_group *)*MAX_NUMNODES, sched_group_nodes = kcalloc(MAX_NUMNODES, sizeof(struct sched_group *),
GFP_KERNEL); GFP_KERNEL);
if (!sched_group_nodes) { if (!sched_group_nodes) {
printk(KERN_WARNING "Can not alloc sched group node list\n"); printk(KERN_WARNING "Can not alloc sched group node list\n");