kpriv/linux-hardened
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

signals: send_sigqueue: don't forget about handle_stop_signal()

Browse source 
send_group_sigqueue() calls handle_stop_signal(), send_sigqueue() doesn't.
This is not consistent and in fact I'd say this is (minor) bug.

Move handle_stop_signal() from send_group_sigqueue() to do_send_sigqueue(),
the latter is called by send_sigqueue() too.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Roland McGrath <roland@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Oleg Nesterov 2008-04-30 00:52:48 -07:00 committed by Linus Torvalds
parent 5c193e8871
commit 5fc894bb4f
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
kernel/signal.c
View file

@ -1274,8 +1274,10 @@ void sigqueue_free(struct sigqueue *q)
} }
static int do_send_sigqueue(int sig, struct sigqueue *q, struct task_struct *t, static int do_send_sigqueue(int sig, struct sigqueue *q, struct task_struct *t,
struct sigpending *pending) struct sigpending *pending)
{ {
handle_stop_signal(sig, t);
if (unlikely(!list_empty(&q->list))) { if (unlikely(!list_empty(&q->list))) {
/* /*
* If an SI_TIMER entry is already queue just increment * If an SI_TIMER entry is already queue just increment
@ -1335,7 +1337,6 @@ send_group_sigqueue(int sig, struct sigqueue *q, struct task_struct *p)
read_lock(&tasklist_lock); read_lock(&tasklist_lock);
/* Since it_lock is held, p->sighand cannot be NULL. */ /* Since it_lock is held, p->sighand cannot be NULL. */
spin_lock_irqsave(&p->sighand->siglock, flags); spin_lock_irqsave(&p->sighand->siglock, flags);
handle_stop_signal(sig, p);
ret = do_send_sigqueue(sig, q, p, &p->signal->shared_pending); ret = do_send_sigqueue(sig, q, p, &p->signal->shared_pending);