kpriv/linux-hardened
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

[media] ti-fpe: LLVMLinux: Remove nested function from ti-vpe

Browse source 
Replace the use of nested functions where a normal function will suffice.

Nested functions are not liked by upstream kernel developers in general. Their
use breaks the use of clang as a compiler, and doesn't make the code any
better.

This code now works for both gcc and clang.

Suggested-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Behan Webster <behanw@converseincode.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
This commit is contained in:
Behan Webster 2014-09-26 22:11:45 -03:00 committed by Mauro Carvalho Chehab
parent 678fa12fb8
commit 61110fbab1
2 changed files with 4 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
drivers/media/platform/ti-vpe/csc.c
View file

@ -93,12 +93,8 @@ void csc_dump_regs(struct csc_data *csc)
{ {
struct device *dev = &csc->pdev->dev; struct device *dev = &csc->pdev->dev;
u32 read_reg(struct csc_data *csc, int offset) #define DUMPREG(r) dev_dbg(dev, "%-35s %08x\n", #r, \
{ ioread32(csc->base + CSC_##r))
return ioread32(csc->base + offset);
}
#define DUMPREG(r) dev_dbg(dev, "%-35s %08x\n", #r, read_reg(csc, CSC_##r))
DUMPREG(CSC00); DUMPREG(CSC00);
DUMPREG(CSC01); DUMPREG(CSC01);

8
drivers/media/platform/ti-vpe/sc.c
View file

@ -24,12 +24,8 @@ void sc_dump_regs(struct sc_data *sc)
{ {
struct device *dev = &sc->pdev->dev; struct device *dev = &sc->pdev->dev;
u32 read_reg(struct sc_data *sc, int offset) #define DUMPREG(r) dev_dbg(dev, "%-35s %08x\n", #r, \
{ ioread32(sc->base + CFG_##r))
return ioread32(sc->base + offset);
}
#define DUMPREG(r) dev_dbg(dev, "%-35s %08x\n", #r, read_reg(sc, CFG_##r))
DUMPREG(SC0); DUMPREG(SC0);
DUMPREG(SC1); DUMPREG(SC1);