kpriv/linux-hardened
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

net: dsa: get and put tree reference counting

Browse source 
Provide convenient dsa_tree_get and dsa_tree_put functions scoping a DSA
tree used to increment and decrement its reference counter, instead of
poking directly its kref structure.

Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Vivien Didelot 2017-11-03 19:05:23 -04:00 committed by David S. Miller
parent 8e5bf9759a
commit 65254108b4
1 changed files with 27 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

38
net/dsa/dsa2.c
View file

@ -38,15 +38,6 @@ static struct dsa_switch_tree *dsa_get_dst(unsigned int index)
return NULL; return NULL;
} }
static void dsa_free_dst(struct kref *ref)
{
struct dsa_switch_tree *dst = container_of(ref, struct dsa_switch_tree,
refcount);
list_del(&dst->list);
kfree(dst);
}
static struct dsa_switch_tree *dsa_add_dst(unsigned int index) static struct dsa_switch_tree *dsa_add_dst(unsigned int index)
{ {
struct dsa_switch_tree *dst; struct dsa_switch_tree *dst;
@ -65,10 +56,35 @@ static struct dsa_switch_tree *dsa_add_dst(unsigned int index)
return dst; return dst;
} }
static void dsa_tree_free(struct dsa_switch_tree *dst)
{
list_del(&dst->list);
kfree(dst);
}
static void dsa_tree_get(struct dsa_switch_tree *dst)
{
kref_get(&dst->refcount);
}
static void dsa_tree_release(struct kref *ref)
{
struct dsa_switch_tree *dst;
dst = container_of(ref, struct dsa_switch_tree, refcount);
dsa_tree_free(dst);
}
static void dsa_tree_put(struct dsa_switch_tree *dst)
{
kref_put(&dst->refcount, dsa_tree_release);
}
static void dsa_dst_add_ds(struct dsa_switch_tree *dst, static void dsa_dst_add_ds(struct dsa_switch_tree *dst,
struct dsa_switch *ds, u32 index) struct dsa_switch *ds, u32 index)
{ {
kref_get(&dst->refcount); dsa_tree_get(dst);
dst->ds[index] = ds; dst->ds[index] = ds;
} }
@ -76,7 +92,7 @@ static void dsa_dst_del_ds(struct dsa_switch_tree *dst,
struct dsa_switch *ds, u32 index) struct dsa_switch *ds, u32 index)
{ {
dst->ds[index] = NULL; dst->ds[index] = NULL;
kref_put(&dst->refcount, dsa_free_dst); dsa_tree_put(dst);
} }
/* For platform data configurations, we need to have a valid name argument to /* For platform data configurations, we need to have a valid name argument to