kpriv/linux-hardened
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

test_hexdump: switch to memcmp()

Browse source 
Better to use memcmp() against entire buffer to check that nothing is
happened to the data in the tail.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Andy Shevchenko 2016-01-20 14:58:58 -08:00 committed by Linus Torvalds
parent ad27a7559a
commit 7047d81371
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
lib/test_hexdump.c
View file

@ -72,8 +72,6 @@ static void __init test_hexdump_prepare_test(size_t len, int rowsize,
else
result = test_data_1_le;
memset(test, FILL_CHAR, testlen);
/* hex dump */
p = test;
for (i = 0; i < l / gs; i++) {
@ -109,13 +107,15 @@ static void __init test_hexdump(size_t len, int rowsize, int groupsize,
char test[TEST_HEXDUMP_BUF_SIZE];
char real[TEST_HEXDUMP_BUF_SIZE];
memset(real, FILL_CHAR, sizeof(real));
hex_dump_to_buffer(data_b, len, rowsize, groupsize, real, sizeof(real),
ascii);
memset(test, FILL_CHAR, sizeof(test));
test_hexdump_prepare_test(len, rowsize, groupsize, test, sizeof(test),
ascii);
if (strcmp(test, real)) {
if (memcmp(test, real, TEST_HEXDUMP_BUF_SIZE)) {
pr_err("Len: %zu row: %d group: %d\n", len, rowsize, groupsize);
pr_err("Result: '%s'\n", real);
pr_err("Expect: '%s'\n", test);