kpriv/linux-hardened
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

net: starfire: remove unnecessary pci_set_drvdata()

Browse source 
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Jingoo Han 2013-10-18 09:18:53 +09:00 committed by David S. Miller
parent 2cb63c7901
commit 705d1c35f4
1 changed files with 0 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/net/ethernet/adaptec/starfire.c
View file

@ -835,7 +835,6 @@ static int starfire_init_one(struct pci_dev *pdev,
return 0; return 0;
err_out_cleardev: err_out_cleardev:
pci_set_drvdata(pdev, NULL);
iounmap(base); iounmap(base);
err_out_free_res: err_out_free_res:
pci_release_regions (pdev); pci_release_regions (pdev);
@ -2012,7 +2011,6 @@ static void starfire_remove_one(struct pci_dev *pdev)
iounmap(np->base); iounmap(np->base);
pci_release_regions(pdev); pci_release_regions(pdev);
pci_set_drvdata(pdev, NULL);
free_netdev(dev); /* Will also free np!! */ free_netdev(dev); /* Will also free np!! */
} }