kpriv/linux-hardened
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

perf tools: Check more combinations of PID/TID, UID and CPU switches

Browse source 
There were some combinations of these switches that are not so
appropriate IMHO.

Since there are implicit priorities between them and they worked well
anyway, but it ends up opening useless duplicated events.

For example, 'perf stat -t <pid> -a' will open multiple events for the
thread instead of one.

Add explicit checks and warn user in perf_target__validate().

Signed-off-by: Namhyung Kim <namhyung.kim@lge.com>
Reviewed-by: David Ahern <dsahern@gmail.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Namhyung Kim <namhyung@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1335417327-11796-7-git-send-email-namhyung.kim@lge.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Namhyung Kim 2012-04-26 14:15:20 +09:00 committed by Arnaldo Carvalho de Melo
parent b809ac100e
commit 770a34a38b
1 changed files with 14 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
tools/perf/util/usage.c
View file

@ -132,4 +132,18 @@ void perf_target__validate(struct perf_target *target)
sleep(1);
target->uid_str = NULL;
}
/* UID and CPU are mutually exclusive */
if (target->uid_str && target->cpu_list) {
ui__warning("UID switch overriding CPU\n");
sleep(1);
target->cpu_list = NULL;
}
/* PID/UID and SYSTEM are mutually exclusive */
if ((target->tid || target->uid_str) && target->system_wide) {
ui__warning("PID/TID/UID switch overriding CPU\n");
sleep(1);
target->system_wide = false;
}
}