kpriv/linux-hardened
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

drivers/base dmam_declare_coherent_memory leaks

Browse source 
dmam_declare_coherent_memory doesn't take into account the return
value of dma_declare_coherent_memory, which leads to incorrect resource
handling

Signed-off-by: Vyacheslav V. Yurkov <uvv.mail@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Vyacheslav V. Yurkov 2016-06-14 09:58:37 +02:00 committed by Greg Kroah-Hartman
parent e330b9a6bb
commit 775115c060
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
drivers/base/dma-mapping.c
View file

@ -198,10 +198,13 @@ int dmam_declare_coherent_memory(struct device *dev, phys_addr_t phys_addr,
rc = dma_declare_coherent_memory(dev, phys_addr, device_addr, size,
flags);
if (rc == 0)
if (rc) {
devres_add(dev, res);
else
rc = 0;
} else {
devres_free(res);
rc = -ENOMEM;
}
return rc;
}