kpriv/linux-hardened
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

bq27x00_battery: use unaligned access helper

Browse source 
Remove hand-rolled get_unaligned_be16, this points to a possible bug as
bq27x00_read does another endian byteswap which sparse notices:

drivers/power/bq27x00_battery.c:81:14: warning: cast to restricted __be16
Which should probably be checked.

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Rodolfo Giometti <giometti@linux.it>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Anton Vorontsov <cbouatmailru@gmail.com>
This commit is contained in:
Harvey Harrison 2008-09-22 14:53:50 -07:00 committed by Anton Vorontsov
parent 6a9037887c
commit 8aef7e8f8d
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
drivers/power/bq27x00_battery.c
View file

@ -23,8 +23,8 @@
#include <linux/platform_device.h>
#include <linux/power_supply.h>
#include <linux/idr.h>
#include <linux/i2c.h>
#include <asm/unaligned.h>
#define DRIVER_VERSION "1.0.0"
@ -33,7 +33,6 @@
#define BQ27x00_REG_RSOC 0x0B /* Relative State-of-Charge */
#define BQ27x00_REG_AI 0x14
#define BQ27x00_REG_FLAGS 0x0A
#define HIGH_BYTE(A) ((A) << 8)
/* If the system has several batteries we need a different name for each
* of them...
@ -239,7 +238,7 @@ static int bq27200_read(u8 reg, int *rt_value, int b_single,
err = i2c_transfer(client->adapter, msg, 1);
if (err >= 0) {
if (!b_single)
*rt_value = data[1] | HIGH_BYTE(data[0]);
*rt_value = get_unaligned_be16(data);
else
*rt_value = data[0];