kpriv/linux-hardened
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Input: tnetv107x-keypad - don't treat NULL clk as an error

Browse source 
We should use IS_ERR() when checking whether clk_get() succeeded or
not since it returns errors by encoding error codes with ERR_PTR().

Signed-off-by: Jamie Iles <jamie@jamieiles.com>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
This commit is contained in:
Jamie Iles 2011-01-17 20:40:32 -08:00 committed by Dmitry Torokhov
parent 01c728a246
commit a064092588
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
drivers/input/keyboard/tnetv107x-keypad.c
View file

@ -14,6 +14,7 @@
*/ */
#include <linux/kernel.h> #include <linux/kernel.h>
#include <linux/err.h>
#include <linux/errno.h> #include <linux/errno.h>
#include <linux/input.h> #include <linux/input.h>
#include <linux/platform_device.h> #include <linux/platform_device.h>
@ -219,9 +220,9 @@ static int __devinit keypad_probe(struct platform_device *pdev)
} }
kp->clk = clk_get(dev, NULL); kp->clk = clk_get(dev, NULL);
if (!kp->clk) { if (IS_ERR(kp->clk)) {
dev_err(dev, "cannot claim device clock\n"); dev_err(dev, "cannot claim device clock\n");
error = -EINVAL; error = PTR_ERR(kp->clk);
goto error_clk; goto error_clk;
} }