kpriv/linux-hardened
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

nfsd: use ARRAY_SIZE

Browse source 
Using the ARRAY_SIZE macro improves the readability of the code.

Found with Coccinelle with the following semantic patch:
@r depends on (org || report)@
type T;
T[] E;
position p;
@@
(
 (sizeof(E)@p /sizeof(*E))
|
 (sizeof(E)@p /sizeof(E[...]))
|
 (sizeof(E)@p /sizeof(T))
)

Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
This commit is contained in:
Jérémy Lefaure 2017-10-01 15:30:47 -04:00 committed by J. Bruce Fields
parent de766e5704
commit a133552a00
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
fs/nfsd/fault_inject.c
View file

@ -11,6 +11,7 @@
#include <linux/nsproxy.h> #include <linux/nsproxy.h>
#include <linux/sunrpc/addr.h> #include <linux/sunrpc/addr.h>
#include <linux/uaccess.h> #include <linux/uaccess.h>
#include <linux/kernel.h>
#include "state.h" #include "state.h"
#include "netns.h" #include "netns.h"
@ -125,8 +126,6 @@ static struct nfsd_fault_inject_op inject_ops[] = {
}, },
}; };
#define NUM_INJECT_OPS (sizeof(inject_ops)/sizeof(struct nfsd_fault_inject_op))
int nfsd_fault_inject_init(void) int nfsd_fault_inject_init(void)
{ {
unsigned int i; unsigned int i;
@ -137,7 +136,7 @@ int nfsd_fault_inject_init(void)
if (!debug_dir) if (!debug_dir)
goto fail; goto fail;
for (i = 0; i < NUM_INJECT_OPS; i++) { for (i = 0; i < ARRAY_SIZE(inject_ops); i++) {
op = &inject_ops[i]; op = &inject_ops[i];
if (!debugfs_create_file(op->file, mode, debug_dir, op, &fops_nfsd)) if (!debugfs_create_file(op->file, mode, debug_dir, op, &fops_nfsd))
goto fail; goto fail;