kpriv/linux-hardened
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

[ARM] 4326/1: S3C24XX: fix sparse errors in DMA code

Browse source 
Fix the following sparse errors in arch/arm/plat-s3c24xx/dma.c:

dma.c:47:30: warning: symbol 'dma_sel' was not declared. Should it be static?
dma.c:883:6: warning: symbol 's3c2410_dma_waitforstop' was not declared. Should it be static?
dma.c:961:1: warning: symbol 's3c2410_dma_started' was not declared. Should it be static?
dma.c:1283:12: warning: symbol 's3c24xx_dma_sysclass_init' was not declared. Should it be static?
dma.c:1295:12: warning: symbol 's3c24xx_dma_sysdev_register' was not declared. Should it be static?
dma.c:1399:25: warning: symbol 's3c2410_dma_map_channel' was not declared. Should it be static?

The patch makes all the relevant functions static.

Signed-off-by: Ben Dooks <ben-linux@fluff.org>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
This commit is contained in:
Ben Dooks 2007-04-20 11:39:46 +01:00 committed by Russell King
parent 57e5171c9f
commit a771743565
1 changed files with 6 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
arch/arm/plat-s3c24xx/dma.c
View file

@ -44,7 +44,7 @@ static struct kmem_cache *dma_kmem;
static int dma_channels; static int dma_channels;
struct s3c24xx_dma_selection dma_sel; static struct s3c24xx_dma_selection dma_sel;
/* dma channel state information */ /* dma channel state information */
struct s3c2410_dma_chan s3c2410_chans[S3C2410_DMA_CHANNELS]; struct s3c2410_dma_chan s3c2410_chans[S3C2410_DMA_CHANNELS];
@ -880,7 +880,7 @@ static int s3c2410_dma_dostop(struct s3c2410_dma_chan *chan)
return 0; return 0;
} }
void s3c2410_dma_waitforstop(struct s3c2410_dma_chan *chan) static void s3c2410_dma_waitforstop(struct s3c2410_dma_chan *chan)
{ {
unsigned long tmp; unsigned long tmp;
unsigned int timeout = 0x10000; unsigned int timeout = 0x10000;
@ -957,8 +957,7 @@ static int s3c2410_dma_flush(struct s3c2410_dma_chan *chan)
return 0; return 0;
} }
int static int s3c2410_dma_started(struct s3c2410_dma_chan *chan)
s3c2410_dma_started(struct s3c2410_dma_chan *chan)
{ {
unsigned long flags; unsigned long flags;
@ -1280,7 +1279,7 @@ static void s3c2410_dma_cache_ctor(void *p, struct kmem_cache *c, unsigned long
/* initialisation code */ /* initialisation code */
int __init s3c24xx_dma_sysclass_init(void) static int __init s3c24xx_dma_sysclass_init(void)
{ {
int ret = sysdev_class_register(&dma_sysclass); int ret = sysdev_class_register(&dma_sysclass);
@ -1292,7 +1291,7 @@ int __init s3c24xx_dma_sysclass_init(void)
core_initcall(s3c24xx_dma_sysclass_init); core_initcall(s3c24xx_dma_sysclass_init);
int __init s3c24xx_dma_sysdev_register(void) static int __init s3c24xx_dma_sysdev_register(void)
{ {
struct s3c2410_dma_chan *cp = s3c2410_chans; struct s3c2410_dma_chan *cp = s3c2410_chans;
int channel, ret; int channel, ret;
@ -1396,7 +1395,7 @@ static struct s3c24xx_dma_order *dma_order;
* channel * channel
*/ */
struct s3c2410_dma_chan *s3c2410_dma_map_channel(int channel) static struct s3c2410_dma_chan *s3c2410_dma_map_channel(int channel)
{ {
struct s3c24xx_dma_order_ch *ord = NULL; struct s3c24xx_dma_order_ch *ord = NULL;
struct s3c24xx_dma_map *ch_map; struct s3c24xx_dma_map *ch_map;