xen-netback: remove redundent parameter in netbk_count_requests
Tracking down from the caller, first_idx is always equal to vif->tx.req_cons. Remove it to avoid confusion. Suggested-by: Jan Beulich <jbeulich@suse.com> Signed-off-by: Wei Liu <wei.liu2@citrix.com> Acked-by: Ian Campbell <ian.campbell@citrix.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
c2bba3dfc1
commit
ac69c26e7a
1 changed files with 2 additions and 4 deletions
|
@ -928,7 +928,6 @@ static void netbk_fatal_tx_err(struct xenvif *vif)
|
||||||
|
|
||||||
static int netbk_count_requests(struct xenvif *vif,
|
static int netbk_count_requests(struct xenvif *vif,
|
||||||
struct xen_netif_tx_request *first,
|
struct xen_netif_tx_request *first,
|
||||||
RING_IDX first_idx,
|
|
||||||
struct xen_netif_tx_request *txp,
|
struct xen_netif_tx_request *txp,
|
||||||
int work_to_do)
|
int work_to_do)
|
||||||
{
|
{
|
||||||
|
@ -1005,7 +1004,7 @@ static int netbk_count_requests(struct xenvif *vif,
|
||||||
} while ((txp++)->flags & XEN_NETTXF_more_data);
|
} while ((txp++)->flags & XEN_NETTXF_more_data);
|
||||||
|
|
||||||
if (drop_err) {
|
if (drop_err) {
|
||||||
netbk_tx_err(vif, first, first_idx + slots);
|
netbk_tx_err(vif, first, cons + slots);
|
||||||
return drop_err;
|
return drop_err;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -1470,8 +1469,7 @@ static unsigned xen_netbk_tx_build_gops(struct xen_netbk *netbk)
|
||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
|
|
||||||
ret = netbk_count_requests(vif, &txreq, idx,
|
ret = netbk_count_requests(vif, &txreq, txfrags, work_to_do);
|
||||||
txfrags, work_to_do);
|
|
||||||
if (unlikely(ret < 0))
|
if (unlikely(ret < 0))
|
||||||
continue;
|
continue;
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue