net: ipmr: limit MRT_TABLE identifiers
Name of pimreg devices are built from following format : char name[IFNAMSIZ]; // IFNAMSIZ == 16 sprintf(name, "pimreg%u", mrt->id); We must therefore limit mrt->id to 9 decimal digits or risk a buffer overflow and a crash. Restrict table identifiers in [0 ... 999999999] interval. Reported-by: Chen Gang <gang.chen@asianux.com> Signed-off-by: Eric Dumazet <edumazet@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
e1a676424c
commit
b49d3c1e1c
1 changed files with 4 additions and 0 deletions
|
@ -1318,6 +1318,10 @@ int ip_mroute_setsockopt(struct sock *sk, int optname, char __user *optval, unsi
|
|||
if (get_user(v, (u32 __user *)optval))
|
||||
return -EFAULT;
|
||||
|
||||
/* "pimreg%u" should not exceed 16 bytes (IFNAMSIZ) */
|
||||
if (v != RT_TABLE_DEFAULT && v >= 1000000000)
|
||||
return -EINVAL;
|
||||
|
||||
rtnl_lock();
|
||||
ret = 0;
|
||||
if (sk == rtnl_dereference(mrt->mroute_sk)) {
|
||||
|
|
Loading…
Reference in a new issue