kpriv/linux-hardened
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

clk: replace pr_warn() with pr_err() for fatal cases

Browse source 
These three cases let clk_register() fail.  They should be considered
as error messages.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Vladimir Zapolskiy <vz@mleia.com>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
This commit is contained in:
Masahiro Yamada 2015-12-28 19:23:03 +09:00 committed by Stephen Boyd
parent 3c436bf95a
commit c44fccb5f7
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
drivers/clk/clk.c
View file

@ -2320,14 +2320,14 @@ static int __clk_core_init(struct clk_core *core)
if (core->ops->set_rate && if (core->ops->set_rate &&
!((core->ops->round_rate || core->ops->determine_rate) && !((core->ops->round_rate || core->ops->determine_rate) &&
core->ops->recalc_rate)) { core->ops->recalc_rate)) {
pr_warning("%s: %s must implement .round_rate or .determine_rate in addition to .recalc_rate\n", pr_err("%s: %s must implement .round_rate or .determine_rate in addition to .recalc_rate\n",
__func__, core->name); __func__, core->name);
ret = -EINVAL; ret = -EINVAL;
goto out; goto out;
} }
if (core->ops->set_parent && !core->ops->get_parent) { if (core->ops->set_parent && !core->ops->get_parent) {
pr_warning("%s: %s must implement .get_parent & .set_parent\n", pr_err("%s: %s must implement .get_parent & .set_parent\n",
__func__, core->name); __func__, core->name);
ret = -EINVAL; ret = -EINVAL;
goto out; goto out;
@ -2335,7 +2335,7 @@ static int __clk_core_init(struct clk_core *core)
if (core->ops->set_rate_and_parent && if (core->ops->set_rate_and_parent &&
!(core->ops->set_parent && core->ops->set_rate)) { !(core->ops->set_parent && core->ops->set_rate)) {
pr_warn("%s: %s must implement .set_parent & .set_rate\n", pr_err("%s: %s must implement .set_parent & .set_rate\n",
__func__, core->name); __func__, core->name);
ret = -EINVAL; ret = -EINVAL;
goto out; goto out;