kpriv/linux-hardened
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

net: dsa: mv88e6xxx: hwtstamp: remove unnecessary range checking tests

Browse source 
_port_ is already known to be a valid index in the callers [1]. So
these checks are unnecessary.

[1] https://lkml.org/lkml/2018/2/16/469

Addresses-Coverity-ID: 1465287
Addresses-Coverity-ID: 1465291
Suggested-by: Richard Cochran <richardcochran@gmail.com>
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Gustavo A. R. Silva 2018-02-16 11:47:39 -06:00 committed by David S. Miller
parent e3f9f41757
commit e21fed5864
1 changed files with 0 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
drivers/net/dsa/mv88e6xxx/hwtstamp.c
View file

@ -179,9 +179,6 @@ int mv88e6xxx_port_hwtstamp_set(struct dsa_switch *ds, int port,
if (!chip->info->ptp_support)
return -EOPNOTSUPP;
if (port < 0 || port >= mv88e6xxx_num_ports(chip))
return -EINVAL;
if (copy_from_user(&config, ifr->ifr_data, sizeof(config)))
return -EFAULT;
@ -206,9 +203,6 @@ int mv88e6xxx_port_hwtstamp_get(struct dsa_switch *ds, int port,
if (!chip->info->ptp_support)
return -EOPNOTSUPP;
if (port < 0 || port >= mv88e6xxx_num_ports(chip))
return -EINVAL;
return copy_to_user(ifr->ifr_data, config, sizeof(*config)) ?
-EFAULT : 0;
}
@ -255,9 +249,6 @@ static u8 *mv88e6xxx_should_tstamp(struct mv88e6xxx_chip *chip, int port,
if (!chip->info->ptp_support)
return NULL;
if (port < 0 || port >= mv88e6xxx_num_ports(chip))
return NULL;
hdr = parse_ptp_header(skb, type);
if (!hdr)
return NULL;