kpriv/linux-hardened
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

ALSA: echoaudio: Fix improper return value in function load_asic

Browse source 
When the second call to load_asic_generic() fails in function
load_asic(), "false" is returned. The real value of "false" is 0, which
indicates success in the context. As a result, the execution status and
the return value may be inconsistent. This patch fixes the bug.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188761
Signed-off-by: Pan Bian <bianpan2016@163.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Pan Bian 2016-11-29 07:33:07 +08:00 committed by Takashi Iwai
parent c6790c8e77
commit e59d8bb574
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
sound/pci/echoaudio/layla24_dsp.c
View file

@ -135,7 +135,7 @@ static int load_asic(struct echoaudio *chip)
err = load_asic_generic(chip, DSP_FNC_LOAD_LAYLA24_EXTERNAL_ASIC, err = load_asic_generic(chip, DSP_FNC_LOAD_LAYLA24_EXTERNAL_ASIC,
FW_LAYLA24_2S_ASIC); FW_LAYLA24_2S_ASIC);
if (err < 0) if (err < 0)
return false; return err;
/* Now give the external ASIC a little time to set up */ /* Now give the external ASIC a little time to set up */
mdelay(10); mdelay(10);