kpriv/linux-hardened
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

rhashtable: Fix cmpxchg RCU warnings

Browse source 
As cmpxchg is a non-RCU mechanism it will cause sparse warnings
when we use it for RCU.  This patch adds explicit casts to silence
those warnings.  This should probably be moved to RCU itself in
future.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Herbert Xu 2019-05-16 15:19:48 +08:00 committed by David S. Miller
parent ba6306e3f6
commit e9458a4e33
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
lib/rhashtable.c
View file

@ -131,7 +131,7 @@ static union nested_table *nested_table_alloc(struct rhashtable *ht,
INIT_RHT_NULLS_HEAD(ntbl[i].bucket); INIT_RHT_NULLS_HEAD(ntbl[i].bucket);
} }
if (cmpxchg(prev, NULL, ntbl) == NULL) if (cmpxchg((union nested_table **)prev, NULL, ntbl) == NULL)
return ntbl; return ntbl;
/* Raced with another thread. */ /* Raced with another thread. */
kfree(ntbl); kfree(ntbl);
@ -296,7 +296,8 @@ static int rhashtable_rehash_attach(struct rhashtable *ht,
* rcu_assign_pointer(). * rcu_assign_pointer().
*/ */
if (cmpxchg(&old_tbl->future_tbl, NULL, new_tbl) != NULL) if (cmpxchg((struct bucket_table **)&old_tbl->future_tbl, NULL,
new_tbl) != NULL)
return -EEXIST; return -EEXIST;
return 0; return 0;