kpriv/linux-hardened
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

[PATCH] hvc_console: start kernel thread before registering tty

Browse source 
Its possible that we can write to the hvc_console tty as soon it is
registered.  Recently this started happening due to (what looks like) a
change to the hotplug code.

Unfortunately at this stage we have not started the khvcd kernel thread and
oops.  The solution is to start the kernel thread before registering the
tty.

Signed-off-by: Anton Blanchard <anton@samba.org>
Cc: Paul Mackerras <paulus@samba.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
Anton Blanchard 2005-09-14 14:19:18 -07:00 committed by Linus Torvalds
parent 8b7fc4214b
commit ef4cbee0b0
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
drivers/char/hvc_console.c
View file

@ -839,9 +839,6 @@ int __init hvc_init(void)
hvc_driver->flags = TTY_DRIVER_REAL_RAW;
tty_set_operations(hvc_driver, &hvc_ops);
if (tty_register_driver(hvc_driver))
panic("Couldn't register hvc console driver\n");
/* Always start the kthread because there can be hotplug vty adapters
* added later. */
hvc_task = kthread_run(khvcd, NULL, "khvcd");
@ -851,6 +848,9 @@ int __init hvc_init(void)
return -EIO;
}
if (tty_register_driver(hvc_driver))
panic("Couldn't register hvc console driver\n");
return 0;
}
module_init(hvc_init);