kpriv/linux-hardened
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

posix_acl: fix reference leaks in posix_acl_create

Browse source 
get_acl gets a reference which we must release in the error cases.

Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Omar Sandoval <osandov@osandov.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
Omar Sandoval 2015-02-08 21:45:25 -08:00 committed by Al Viro
parent 76bf3f6b1d
commit fed0b588be
1 changed files with 9 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
fs/posix_acl.c
View file

@ -564,13 +564,11 @@ posix_acl_create(struct inode *dir, umode_t *mode,
*acl = posix_acl_clone(p, GFP_NOFS); *acl = posix_acl_clone(p, GFP_NOFS);
if (!*acl) if (!*acl)
return -ENOMEM; goto no_mem;
ret = posix_acl_create_masq(*acl, mode); ret = posix_acl_create_masq(*acl, mode);
if (ret < 0) { if (ret < 0)
posix_acl_release(*acl); goto no_mem_clone;
return -ENOMEM;
}
if (ret == 0) { if (ret == 0) {
posix_acl_release(*acl); posix_acl_release(*acl);
@ -591,6 +589,12 @@ no_acl:
*default_acl = NULL; *default_acl = NULL;
*acl = NULL; *acl = NULL;
return 0; return 0;
no_mem_clone:
posix_acl_release(*acl);
no_mem:
posix_acl_release(p);
return -ENOMEM;
} }
EXPORT_SYMBOL_GPL(posix_acl_create); EXPORT_SYMBOL_GPL(posix_acl_create);