linux-hardened/drivers/firewire
Stefan Richter 148c7866c3 firewire: ohci: do not enable interrupts without the handler
On 26 Apr 2010, Clemens Ladisch wrote:
> In theory, none of the interrupts should occur before the link is
> enabled.  In practice, I'd rather make sure to not set the master
> interrupt enable bit until we have installed the interrupt handler.

and proposed to move OHCI1394_masterIntEnable out of the present
reg_write() into a new one before the HCControl.linkEnable reg_write().

Why not defer setting /all/ of the bits until right before linkEnable?

Reviewed-by: Clemens Ladisch <clemens@ladisch.de>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
2010-06-09 19:42:18 +02:00
..
core-card.c firewire: core: use separate timeout for each transaction 2010-05-19 00:26:30 +02:00
core-cdev.c firewire: cdev: mark char device files as not seekable 2010-04-10 16:51:14 +02:00
core-device.c firewire: core: align driver match with modalias 2010-03-24 22:01:47 +01:00
core-iso.c firewire: core: fw_iso_resource_manage: fix error handling 2010-03-15 14:29:44 +01:00
core-topology.c Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial 2009-12-09 19:43:33 -08:00
core-transaction.c firewire: core: use separate timeout for each transaction 2010-05-19 00:26:30 +02:00
core.h firewire: core: use separate timeout for each transaction 2010-05-19 00:26:30 +02:00
Kconfig firewire, ieee1394: update Kconfig help 2009-12-29 19:58:17 +01:00
Makefile firewire: net: add Kconfig item, rename driver 2009-06-14 14:26:29 +02:00
net.c firewire: net: fix panic in fwnet_write_complete 2010-02-01 21:51:28 +01:00
ohci.c firewire: ohci: do not enable interrupts without the handler 2010-06-09 19:42:18 +02:00
ohci.h firewire: ohci: fix up configuration of TI chips 2010-04-10 16:51:14 +02:00
sbp2.c firewire: qualify config ROM cache pointers as const pointers 2009-12-29 19:58:17 +01:00