7d40d7e85a
The id_table field of the struct usb_device_id is constant in <linux/usb.h> so it is worth to make the initialization data also constant. The semantic match that finds this kind of pattern is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r@ disable decl_init,const_decl_init; identifier I1, I2, x; @@ struct I1 { ... const struct I2 *x; ... }; @s@ identifier r.I1, y; identifier r.x, E; @@ struct I1 y = { .x = E, }; @c@ identifier r.I2; identifier s.E; @@ const struct I2 E[] = ... ; @depends on !c@ identifier r.I2; identifier s.E; @@ + const struct I2 E[] = ...; // </smpl> Signed-off-by: Németh Márton <nm127@freemail.hu> Cc: Julia Lawall <julia@diku.dk> Cc: cocci@diku.dk Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
71 lines
1.8 KiB
C
71 lines
1.8 KiB
C
/*
|
|
* Motorola USB Phone driver
|
|
*
|
|
* Copyright (C) 2008 Greg Kroah-Hartman <greg@kroah.com>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License version 2 as
|
|
* published by the Free Software Foundation.
|
|
*
|
|
* {sigh}
|
|
* Motorola should be using the CDC ACM USB spec, but instead
|
|
* they try to just "do their own thing"... This driver should handle a
|
|
* few phones in which a basic "dumb serial connection" is needed to be
|
|
* able to get a connection through to them.
|
|
*/
|
|
|
|
#include <linux/kernel.h>
|
|
#include <linux/init.h>
|
|
#include <linux/tty.h>
|
|
#include <linux/module.h>
|
|
#include <linux/usb.h>
|
|
#include <linux/usb/serial.h>
|
|
|
|
static const struct usb_device_id id_table[] = {
|
|
{ USB_DEVICE(0x05c6, 0x3197) }, /* unknown Motorola phone */
|
|
{ USB_DEVICE(0x0c44, 0x0022) }, /* unknown Mororola phone */
|
|
{ USB_DEVICE(0x22b8, 0x2a64) }, /* Motorola KRZR K1m */
|
|
{ USB_DEVICE(0x22b8, 0x2c64) }, /* Motorola V950 phone */
|
|
{ },
|
|
};
|
|
MODULE_DEVICE_TABLE(usb, id_table);
|
|
|
|
static struct usb_driver moto_driver = {
|
|
.name = "moto-modem",
|
|
.probe = usb_serial_probe,
|
|
.disconnect = usb_serial_disconnect,
|
|
.id_table = id_table,
|
|
.no_dynamic_id = 1,
|
|
};
|
|
|
|
static struct usb_serial_driver moto_device = {
|
|
.driver = {
|
|
.owner = THIS_MODULE,
|
|
.name = "moto-modem",
|
|
},
|
|
.id_table = id_table,
|
|
.num_ports = 1,
|
|
};
|
|
|
|
static int __init moto_init(void)
|
|
{
|
|
int retval;
|
|
|
|
retval = usb_serial_register(&moto_device);
|
|
if (retval)
|
|
return retval;
|
|
retval = usb_register(&moto_driver);
|
|
if (retval)
|
|
usb_serial_deregister(&moto_device);
|
|
return retval;
|
|
}
|
|
|
|
static void __exit moto_exit(void)
|
|
{
|
|
usb_deregister(&moto_driver);
|
|
usb_serial_deregister(&moto_device);
|
|
}
|
|
|
|
module_init(moto_init);
|
|
module_exit(moto_exit);
|
|
MODULE_LICENSE("GPL");
|