linux-hardened/net/ncsi
Arnd Bergmann a1b43eddae net/ncsi: avoid maybe-uninitialized warning
gcc-4.9 and higher warn about the newly added NSCI code:

net/ncsi/ncsi-manage.c: In function 'ncsi_process_next_channel':
net/ncsi/ncsi-manage.c:1003:2: error: 'old_state' may be used uninitialized in this function [-Werror=maybe-uninitialized]

The warning is a false positive and therefore harmless, but it would be good to
avoid it anyway. I have determined that the barrier in the spin_unlock_irqsave()
is what confuses gcc to the point that it cannot track whether the variable
was unused or not.

This rearranges the code in a way that makes it obvious to gcc that old_state
is always initialized at the time of use, functionally this should not
change anything.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2016-07-25 10:32:59 -07:00
..
internal.h net/ncsi: NCSI AEN packet handler 2016-07-19 20:49:17 -07:00
Kconfig
Makefile net/ncsi: NCSI AEN packet handler 2016-07-19 20:49:17 -07:00
ncsi-aen.c net/ncsi: NCSI AEN packet handler 2016-07-19 20:49:17 -07:00
ncsi-cmd.c net/ncsi: NCSI command packet handler 2016-07-19 20:49:16 -07:00
ncsi-manage.c net/ncsi: avoid maybe-uninitialized warning 2016-07-25 10:32:59 -07:00
ncsi-pkt.h net/ncsi: NCSI AEN packet handler 2016-07-19 20:49:17 -07:00
ncsi-rsp.c net/ncsi: NCSI AEN packet handler 2016-07-19 20:49:17 -07:00