linux-hardened/fs/orangefs
Ingo Molnar 2055da9738 sched/wait: Disambiguate wq_entry->task_list and wq_head->task_list naming
So I've noticed a number of instances where it was not obvious from the
code whether ->task_list was for a wait-queue head or a wait-queue entry.

Furthermore, there's a number of wait-queue users where the lists are
not for 'tasks' but other entities (poll tables, etc.), in which case
the 'task_list' name is actively confusing.

To clear this all up, name the wait-queue head and entry list structure
fields unambiguously:

	struct wait_queue_head::task_list	=> ::head
	struct wait_queue_entry::task_list	=> ::entry

For example, this code:

	rqw->wait.task_list.next != &wait->task_list

... is was pretty unclear (to me) what it's doing, while now it's written this way:

	rqw->wait.head.next != &wait->entry

... which makes it pretty clear that we are iterating a list until we see the head.

Other examples are:

	list_for_each_entry_safe(pos, next, &x->task_list, task_list) {
	list_for_each_entry(wq, &fence->wait.task_list, task_list) {

... where it's unclear (to me) what we are iterating, and during review it's
hard to tell whether it's trying to walk a wait-queue entry (which would be
a bug), while now it's written as:

	list_for_each_entry_safe(pos, next, &x->head, entry) {
	list_for_each_entry(wq, &fence->wait.head, entry) {

Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
2017-06-20 12:19:14 +02:00
..
acl.c posix_acl: Clear SGID bit when setting file permissions 2016-09-22 10:55:32 +02:00
dcache.c orangefs: don't use d_time 2016-10-24 14:50:07 -04:00
devorangefs-req.c orangefs: return from orangefs_devreq_read quickly if possible 2017-04-26 14:33:00 -04:00
dir.c orangefs: count directory pieces correctly 2017-05-04 14:38:24 -04:00
downcall.h orangefs: rewrite readdir to fix several bugs 2017-04-26 14:33:00 -04:00
file.c Some cleanups: 2017-05-05 13:36:10 -07:00
inode.c orangefs: do not check possibly stale size on truncate 2017-04-26 14:33:00 -04:00
Kconfig Orangefs: kernel client part 7 2015-10-03 11:40:00 -04:00
Makefile Orangefs: change pvfs2 filenames to orangefs 2015-12-04 12:56:14 -05:00
namei.c orangefs: implement statx 2017-04-26 14:33:00 -04:00
orangefs-bufmap.c sched/wait: Disambiguate wq_entry->task_list and wq_head->task_list naming 2017-06-20 12:19:14 +02:00
orangefs-bufmap.h orangefs-bufmap.h: trim unused junk 2016-03-25 22:30:54 -04:00
orangefs-cache.c orangefs: add features op 2016-08-12 15:12:54 -04:00
orangefs-debug.h Orangef: remove overlooked old-style userspace debug parts 2015-12-11 11:00:12 -05:00
orangefs-debugfs.c orangefs: handle zero size write in debugfs 2017-04-26 14:33:01 -04:00
orangefs-debugfs.h orangefs: clean up debugfs globals 2016-08-15 11:38:36 -04:00
orangefs-dev-proto.h orangefs: rewrite readdir to fix several bugs 2017-04-26 14:33:00 -04:00
orangefs-kernel.h orangefs: implement statx 2017-04-26 14:33:00 -04:00
orangefs-mod.c orangefs: Remove orangefs_backing_dev_info 2017-02-03 14:38:35 -05:00
orangefs-sysfs.c orangefs: Support readahead_readcnt parameter. 2017-02-03 14:38:28 -05:00
orangefs-sysfs.h Orangefs: change pvfs2 filenames to orangefs 2015-12-04 12:56:14 -05:00
orangefs-utils.c orangefs: ensure the userspace component is unmounted if mount fails 2017-04-26 14:33:00 -04:00
protocol.h orangefs: remove ORANGEFS_READDIR macros 2017-04-26 14:33:00 -04:00
super.c orangefs: ensure the userspace component is unmounted if mount fails 2017-04-26 14:33:00 -04:00
symlink.c vfs: remove ".readlink = generic_readlink" assignments 2016-12-09 16:45:04 +01:00
upcall.h orangefs: Support readahead_readcnt parameter. 2017-02-03 14:38:28 -05:00
waitqueue.c orangefs: do not wait for timeout if umounting 2017-04-26 14:33:01 -04:00
xattr.c orangefs: clean up oversize xattr validation 2017-04-26 14:33:00 -04:00