e8edc6e03a
First thing mm.h does is including sched.h solely for can_do_mlock() inline function which has "current" dereference inside. By dealing with can_do_mlock() mm.h can be detached from sched.h which is good. See below, why. This patch a) removes unconditional inclusion of sched.h from mm.h b) makes can_do_mlock() normal function in mm/mlock.c c) exports can_do_mlock() to not break compilation d) adds sched.h inclusions back to files that were getting it indirectly. e) adds less bloated headers to some files (asm/signal.h, jiffies.h) that were getting them indirectly Net result is: a) mm.h users would get less code to open, read, preprocess, parse, ... if they don't need sched.h b) sched.h stops being dependency for significant number of files: on x86_64 allmodconfig touching sched.h results in recompile of 4083 files, after patch it's only 3744 (-8.3%). Cross-compile tested on all arm defconfigs, all mips defconfigs, all powerpc defconfigs, alpha alpha-up arm i386 i386-up i386-defconfig i386-allnoconfig ia64 ia64-up m68k mips parisc parisc-up powerpc powerpc-up s390 s390-up sparc sparc-up sparc64 sparc64-up um-x86_64 x86_64 x86_64-up x86_64-defconfig x86_64-allnoconfig as well as my two usual configs. Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
79 lines
1.7 KiB
C
79 lines
1.7 KiB
C
#include <linux/vmalloc.h>
|
|
#include <linux/module.h>
|
|
#include <linux/fs.h>
|
|
#include <linux/mm.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/sched.h>
|
|
#include <asm/uaccess.h>
|
|
#include "oss/sound_firmware.h"
|
|
|
|
static int do_mod_firmware_load(const char *fn, char **fp)
|
|
{
|
|
struct file* filp;
|
|
long l;
|
|
char *dp;
|
|
loff_t pos;
|
|
|
|
filp = filp_open(fn, 0, 0);
|
|
if (IS_ERR(filp))
|
|
{
|
|
printk(KERN_INFO "Unable to load '%s'.\n", fn);
|
|
return 0;
|
|
}
|
|
l = filp->f_path.dentry->d_inode->i_size;
|
|
if (l <= 0 || l > 131072)
|
|
{
|
|
printk(KERN_INFO "Invalid firmware '%s'\n", fn);
|
|
filp_close(filp, current->files);
|
|
return 0;
|
|
}
|
|
dp = vmalloc(l);
|
|
if (dp == NULL)
|
|
{
|
|
printk(KERN_INFO "Out of memory loading '%s'.\n", fn);
|
|
filp_close(filp, current->files);
|
|
return 0;
|
|
}
|
|
pos = 0;
|
|
if (vfs_read(filp, dp, l, &pos) != l)
|
|
{
|
|
printk(KERN_INFO "Failed to read '%s'.\n", fn);
|
|
vfree(dp);
|
|
filp_close(filp, current->files);
|
|
return 0;
|
|
}
|
|
filp_close(filp, current->files);
|
|
*fp = dp;
|
|
return (int) l;
|
|
}
|
|
|
|
/**
|
|
* mod_firmware_load - load sound driver firmware
|
|
* @fn: filename
|
|
* @fp: return for the buffer.
|
|
*
|
|
* Load the firmware for a sound module (up to 128K) into a buffer.
|
|
* The buffer is returned in *fp. It is allocated with vmalloc so is
|
|
* virtually linear and not DMAable. The caller should free it with
|
|
* vfree when finished.
|
|
*
|
|
* The length of the buffer is returned on a successful load, the
|
|
* value zero on a failure.
|
|
*
|
|
* Caution: This API is not recommended. Firmware should be loaded via
|
|
* request_firmware.
|
|
*/
|
|
|
|
int mod_firmware_load(const char *fn, char **fp)
|
|
{
|
|
int r;
|
|
mm_segment_t fs = get_fs();
|
|
|
|
set_fs(get_ds());
|
|
r = do_mod_firmware_load(fn, fp);
|
|
set_fs(fs);
|
|
return r;
|
|
}
|
|
EXPORT_SYMBOL(mod_firmware_load);
|
|
|
|
MODULE_LICENSE("GPL");
|