kpriv/pkgsrc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
pkgsrc/multimedia/openquicktime/buildlink3.mk

22 lines
673 B
Makefile
Raw Normal View History

Fix serious bug where BUILDLINK_PACKAGES wasn't being ordered properly by moving the inclusion of buildlink3.mk files outside of the protected region. This bug would be seen by users that have set PREFER_PKGSRC or PREFER_NATIVE to non-default values. BUILDLINK_PACKAGES should be ordered so that for any package in the list, that package doesn't depend on any packages to the left of it in the list. This ordering property is used to check for builtin packages in the correct order. The problem was that including a buildlink3.mk file for <pkg> correctly ensured that <pkg> was removed from BUILDLINK_PACKAGES and appended to the end. However, since the inclusion of any other buildlink3.mk files within that buildlink3.mk was in a region that was protected against multiple inclusion, those dependencies weren't also moved to the end of BUILDLINK_PACKAGES.
2004-03-18 10:12:08 +01:00
# $NetBSD: buildlink3.mk,v 1.2 2004/03/18 09:12:13 jlam Exp $
Move openquicktime from the graphics to the multimedia category. This is version 1.0nb2.
2004-03-06 12:09:40 +01:00
BUILDLINK_DEPTH:= ${BUILDLINK_DEPTH}+
OPENQUICKTIME_BUILDLINK3_MK:= ${OPENQUICKTIME_BUILDLINK3_MK}+
.if !empty(BUILDLINK_DEPTH:M+)
BUILDLINK_DEPENDS+= openquicktime
.endif
BUILDLINK_PACKAGES:= ${BUILDLINK_PACKAGES:Nopenquicktime}
BUILDLINK_PACKAGES+= openquicktime
.if !empty(OPENQUICKTIME_BUILDLINK3_MK:M+)
BUILDLINK_DEPENDS.openquicktime+= openquicktime>=1.0nb2
BUILDLINK_PKGSRCDIR.openquicktime?= ../../multimedia/openquicktime
Fix serious bug where BUILDLINK_PACKAGES wasn't being ordered properly by moving the inclusion of buildlink3.mk files outside of the protected region. This bug would be seen by users that have set PREFER_PKGSRC or PREFER_NATIVE to non-default values. BUILDLINK_PACKAGES should be ordered so that for any package in the list, that package doesn't depend on any packages to the left of it in the list. This ordering property is used to check for builtin packages in the correct order. The problem was that including a buildlink3.mk file for <pkg> correctly ensured that <pkg> was removed from BUILDLINK_PACKAGES and appended to the end. However, since the inclusion of any other buildlink3.mk files within that buildlink3.mk was in a region that was protected against multiple inclusion, those dependencies weren't also moved to the end of BUILDLINK_PACKAGES.
2004-03-18 10:12:08 +01:00
.endif # OPENQUICKTIME_BUILDLINK3_MK
Move openquicktime from the graphics to the multimedia category. This is version 1.0nb2.
2004-03-06 12:09:40 +01:00
.include "../../devel/glib2/buildlink3.mk"
.include "../../graphics/jpeg/buildlink3.mk"
BUILDLINK_DEPTH:= ${BUILDLINK_DEPTH:S/+$//}
Reference in a new issue Copy permalink