pkgsrc/pkgtools/pkglint/TODO

39 lines
1.9 KiB
Text
Raw Normal View History

$NetBSD: TODO,v 1.53 2006/10/12 13:58:48 joerg Exp $
Please add your own entries at the bottom of this file. If possible,
include the name of an example package where a warning should occur.
2005-04-30 13:50:42 +02:00
* fix false positive warnings
* ONLY_FOR_PLATFORM => NOT_FOR_PLATFORM
* -Wl,-rpath
* include "../../mk/bsd.prefs.mk" before using "+=".
* include "../../mk/bsd.prefs.mk" before any .if
* warn about the use of ${SED} in {pre,do,post}-install
* check for direct use of user names and group names
* Find a reliable, secure way to delete all CVS directories inside
${WRKSRC}. When that is finished, add a warning that using ${XARGS}
is insecure.
* warn about the use of ${WRKDIR:=...}, as this construct should only
be used with lists.
* record with each substring its source location to be able to make
even more precise diagnostics
* check wether CONFIG* override match, e.g. CONFIGURE_DIRS most likely
needs matching CNOFIG_GUESS_OVERRIDE and CONFIG_SUB_OVERRIDE as well
* warn about BUILD_USES_MSGFMT and related defines being used when
devel/gettext-lib/buildlink3.mk is not explicitly included?
* Many of the checking routines need some context to provide better
warnings. For example, checkline_foo() may need to know what has
happened in the file before that line.
* Add checks for binary packages. See Debian/lintian for ideas.
2006-06-03 02:12:38 +02:00
* Of the user-defined variables, some may be used at load-time and some
don't. Find out how pkglint can distinguish them.
Updated pkglint to 4.66. This change includes all the things I thought of during the freeze of 2006Q2. Some variables have disappeared from pkgsrc without notice. Marked them deprecated to help the package authors at least a bit. Renamed some ACL abbreviations in makevars.map and adjusted the variable definitions. Added the command line options -Dtrace, -Dunchecked and -Dunused. Some variables may contain unexpected white-space and therefore should not be used in .for loops. The -Dmisc option replaces the --verbose option (and the log_info subroutine), which does not exist any longer. This eliminates all instances of "OK:" from the output, which I didn't like from the beginning. The -Dmisc option also takes over many warnings that have been issued by --debug before. Improved the check for absolute pathnames. Especially, everything that follows ${DESTDIR} or $(DESTDIR) in a Makefile is considered an absolute pathname. This reveals many wrong uses of DESTDIR (as defined by the GNU coding standards), for example $(DESTDIR)/$(prefix), which should be $(DESTDIR)$(prefix) instead. Almost every use of a make(1) variable is checked for spelling mistakes. Before, only the definitions of variables have been checked. Restricted the use of variables to specific files, which are defined in makevars.map. This catches especially buildlink3.mk files with unexpected side effects. In shell commands, neither "echo" nor "echo -n" or "${ECHO} -n" should be used. Since the INSTALL_*_DIR commands can only handle one directory at a time, suggest to use INSTALLATION_DIRS instead. Greatly improved the checks for dependency specifications, especially to find foo-*, which should rather be foo-[0-9]*. Fixed the incorrect handling of LICENSE_FILE (now using $line->text instead of $line). Improved the wording of the "plural names" warnings, so that for known variables it is "The += operator should only be used with lists." now. In buildlink3.mk files the uppercase and lowercase names of the package should correspond with the package name. This catches many copy-and-paste mistakes. Fixed many null pointer exceptions as well. In addition, every buildlink3.mk file needs a definition of BUILDLINK_API_DEPENDS. In patch files, absolute pathnames and unportable macro names are checked not only in added lines, but also in the context lines. In the pkgsrc root directory and the category directories, the Makefiles are checked like every other Makefile, too. Fixed the place where the global variables for the package context are defined and later undefined. Variables that are mentioned in EVAL_PREFIX may be used in the current file and are not flagged as "used but not defined". When parsing shell words in Makefiles, recognize $<, $@, $^ and $/. (The latter is used extensively by openoffice to represent a directory separator.) Fixed some minor bugs: * $makevar had been defined unintentionally by using the -> operator.
2006-07-02 11:47:17 +02:00
* Make sure that no variable is modified at load-time after it has been
used once. This should at least flag BUILD_DEFS in bsd.pkg.mk.
* Implement unescape_shellword, which is required for the type check for
SedCommand.
* Invent an annotation scheme for files that intentionally define
variables for use in other files.
* Check all the shell commands to see if they are mentioned in USE_TOOLS.
* ${MACHINE_ARCH}-${LOWER_OPSYS}elf in PLISTs etc. is a NetBSD config.guess
problem ==> use of ${APPEND_ELF}