kpriv/pkgsrc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
pkgsrc/pkgtools/pkglint/Makefile

79 lines
2.4 KiB
Makefile
Raw Normal View History

pkgtools/pkglint: update to 20.2.1 Changes since 20.2.0: Don't warn about a possibly redundant PKGNAME=${DISTNAME} assignment if PKGNAME is defined somewhere else in the package Makefile. Warn if NO_CONFIGURE=yes and REPLACE_* are combined. Suggest to replace ${VAR:@l@-l${l}@} with the simpler ${VAR:S,^,-l,}, as well as ${VAR:@l@${l}suffix@} with the simpler ${VAR:=suffix}. Allow lua in CATEGORIES.
2020-07-01 15:17:41 +02:00
# $NetBSD: Makefile,v 1.661 2020/07/01 13:17:41 rillig Exp $
Our portlint has diverged significantly from FreeBSD's, so rename portlint to pkglint, and keep the sources right under files. This makes it much easier to maintain and keep up with changes to out package system.
1998-08-08 00:11:40 +02:00
pkgtools/pkglint: update to 20.2.1 Changes since 20.2.0: Don't warn about a possibly redundant PKGNAME=${DISTNAME} assignment if PKGNAME is defined somewhere else in the package Makefile. Warn if NO_CONFIGURE=yes and REPLACE_* are combined. Suggest to replace ${VAR:@l@-l${l}@} with the simpler ${VAR:S,^,-l,}, as well as ${VAR:@l@${l}suffix@} with the simpler ${VAR:=suffix}. Allow lua in CATEGORIES.
2020-07-01 15:17:41 +02:00
PKGNAME= pkglint-20.2.1
Updated pkglint to 4.45. - Fixed perl -T warnings: - Replaced $#{@{$lines}} with $#{$lines}. - Avoided calls to external programs (sed and digest). - Removed redundant warning if DISTNAME is set to an invalid package name and PKGNAME is not defined. - Changed dependency from pkgtools/digest to security/p5-Digest-SHA1.
2005-11-21 23:06:30 +01:00
CATEGORIES= pkgtools
pkgtools/pkglint: don't access the internet during the build Pkglint needs goyacc, which is provided by devel/go-tools. But that packages pulls in a lot of dependencies that are not needed for pkglint. This includes a Perl interpreter and various cryptography packages. Instead, during build, pkglint installs the only needed tool of that collection (goyacc). Since go-package.mk assumes that each pkgsrc package only downloads and installs a single project, but pkglint now needs two of them (goyacc and pkglint), most parts of go-package.mk had to be copied here and implemented directly.
2018-11-10 12:41:40 +01:00
DISTNAME= tools
MASTER_SITES= ${MASTER_SITE_GITHUB:=golang/}
GITHUB_PROJECT= tools
GITHUB_TAG= 92d8274bd7b8a4c65f24bafe401a029e58392704
Our portlint has diverged significantly from FreeBSD's, so rename portlint to pkglint, and keep the sources right under files. This makes it much easier to maintain and keep up with changes to out package system.
1998-08-08 00:11:40 +02:00
Updated pkglint to 5.4.12. Changes since 5.4.11: * warn when PKGSRC_COMPILER is compared with "==", since it may be a chain of compilers * warn about listing Python .egg-info files directly in PLIST files, since lang/python/egg.mk takes care of this * code cleanup: unify Error{0,1,2,3} into Errorf to make understanding the code easier; use interface{} for MkLine data; use regular expression instead of handwritten matching code, since one line is easier to read than 50
2016-12-04 16:28:36 +01:00
MAINTAINER= rillig@NetBSD.org
pkgtools/pkglint: update HOMEPAGE
2018-01-28 14:40:22 +01:00
HOMEPAGE= https://github.com/rillig/pkglint
Updated pkglint to 4.82. Changes since 4.81: - Moved lintpkgsrc to its own package. - Less internal errors when parsing shell code. - White-space checks in PLIST.
2008-01-04 16:59:47 +01:00
COMMENT= Verifier for NetBSD packages
- Added check for unused license files - Improved allowed filenames for patches - Added license for pkglint itself - Cleaned up Makefile and TODO
2013-10-12 20:09:59 +02:00
LICENSE= 2-clause-bsd
Explicitly added conflict with pkglint4
2015-11-25 17:53:18 +01:00
CONFLICTS+= pkglint4-[0-9]*
Our portlint has diverged significantly from FreeBSD's, so rename portlint to pkglint, and keep the sources right under files. This makes it much easier to maintain and keep up with changes to out package system.
1998-08-08 00:11:40 +02:00
pkgtools/pkglint: don't access the internet during the build Pkglint needs goyacc, which is provided by devel/go-tools. But that packages pulls in a lot of dependencies that are not needed for pkglint. This includes a Perl interpreter and various cryptography packages. Instead, during build, pkglint installs the only needed tool of that collection (goyacc). Since go-package.mk assumes that each pkgsrc package only downloads and installs a single project, but pkglint now needs two of them (goyacc and pkglint), most parts of go-package.mk had to be copied here and implemented directly.
2018-11-10 12:41:40 +01:00
USE_TOOLS+= pax
AUTO_MKDIRS= yes
GO_SRCPATH= golang.org/x/tools
GO_DIST_BASE= ${GO_SRCPATH}
GO_BUILD_PATTERN= netbsd.org/pkglint/...
Before using any variables in .if conditionaly, bsd.prefs.mk should be included. In the special case of the BATCH variable, this does not make a difference, since it is set via an environment variable.
2007-04-16 01:02:04 +02:00
Sprinkle CHECK_RELRO_SKIP on go packages. go14 has no relro support AFAICT. go-1.8.3 has if you use -buildmode=pie, but it claims it's not supported on Linux. Disable relro checking for go packages until bsiegert has time to look at this.
2017-07-22 21:32:40 +02:00
CHECK_RELRO_SKIP+= bin/pkglint
Update to 3.93, from Roland Illig: - Renamed PORTSDIR to PKGSRCDIR - Added warning option -Wno-workdir - Fixed some places where absolute and relative pathnames had been used incorrectly. Clean up Makefile.
2004-10-16 17:04:26 +02:00
SUBST_CLASSES+= pkglint
Converted USE_PERL5 into USE_TOOLS. Changed the SUBST stage to post-configure. Removed DISTVER variable.
2005-05-24 23:24:30 +02:00
SUBST_STAGE.pkglint= post-configure
pkgtools/pkglint: don't access the internet during the build Pkglint needs goyacc, which is provided by devel/go-tools. But that packages pulls in a lot of dependencies that are not needed for pkglint. This includes a Perl interpreter and various cryptography packages. Instead, during build, pkglint installs the only needed tool of that collection (goyacc). Since go-package.mk assumes that each pkgsrc package only downloads and installs a single project, but pkglint now needs two of them (goyacc and pkglint), most parts of go-package.mk had to be copied here and implemented directly.
2018-11-10 12:41:40 +01:00
SUBST_FILES.pkglint+= ${WRKSRC.pkglint}/pkglint.go
SUBST_SED.pkglint+= -e s\|@VERSION@\|${PKGVERSION}\|g
pkgtools/pkglint: make the tests run cleanly
2018-08-09 22:21:42 +02:00
SUBST_SED.pkglint+= -e s\|@BMAKE@\|${MAKE:T:Q}\|g
Make this package work on Solaris.
1999-07-02 15:57:56 +02:00
pkgtools/pkglint: ignore hidden files during extraction Fixes pkg/54204.
2019-05-26 15:52:14 +02:00
EXTRACT_PAX_ARGS= -s ',.*/CVS$$,,' -s ',.*/CVS/.*,,' -s ',.*/\..*,,'
pkgtools/pkglint: don't access the internet during the build Pkglint needs goyacc, which is provided by devel/go-tools. But that packages pulls in a lot of dependencies that are not needed for pkglint. This includes a Perl interpreter and various cryptography packages. Instead, during build, pkglint installs the only needed tool of that collection (goyacc). Since go-package.mk assumes that each pkgsrc package only downloads and installs a single project, but pkglint now needs two of them (goyacc and pkglint), most parts of go-package.mk had to be copied here and implemented directly.
2018-11-10 12:41:40 +01:00
WRKSRC.tools= ${WRKSRC}/golang.org/x/tools
WRKSRC.pkglint= ${WRKSRC}/netbsd.org/pkglint
pkgtools/pkglint: make goyacc accessible to the build
2018-11-11 21:55:23 +01:00
PREPEND_PATH+= ${WRKDIR}/bin # for goyacc
pkgtools/pkglint: don't access the internet during the build Pkglint needs goyacc, which is provided by devel/go-tools. But that packages pulls in a lot of dependencies that are not needed for pkglint. This includes a Perl interpreter and various cryptography packages. Instead, during build, pkglint installs the only needed tool of that collection (goyacc). Since go-package.mk assumes that each pkgsrc package only downloads and installs a single project, but pkglint now needs two of them (goyacc and pkglint), most parts of go-package.mk had to be copied here and implemented directly.
2018-11-10 12:41:40 +01:00
post-extract:
${RUN} ${MKDIR} ${WRKSRC.pkglint}
${RUN} cd ${FILESDIR} && ${PAX} -rw ${EXTRACT_PAX_ARGS} . ${WRKSRC.pkglint}
${RUN} ${MKDIR} ${WRKSRC.tools}
${RUN} ${MV} ${WRKDIR}/tools-*/* ${WRKSRC.tools}
pkgtools/pkglint: update to 5.6.6 Changes since 5.6.5: - Removed plist-clash since it had crashed unconditionally whenever it was called. This means that in the last 3 years, nobody can have used it in the originally intended way. - Fixed interactions between the --source, --explain, --show-autofix, --autofix and --only options. - Fixed "defined but not used" and "used but not defined" for variables from the pkgsrc infrastructure. - Lots of small fixes and improvements found by the large pkglint code review (12% done).
2018-11-07 21:58:22 +01:00
pre-build:
pkgtools/pkglint: don't access the internet during the build Pkglint needs goyacc, which is provided by devel/go-tools. But that packages pulls in a lot of dependencies that are not needed for pkglint. This includes a Perl interpreter and various cryptography packages. Instead, during build, pkglint installs the only needed tool of that collection (goyacc). Since go-package.mk assumes that each pkgsrc package only downloads and installs a single project, but pkglint now needs two of them (goyacc and pkglint), most parts of go-package.mk had to be copied here and implemented directly.
2018-11-10 12:41:40 +01:00
${RUN} ${PKGSRC_SETENV} ${MAKE_ENV} ${GO} install -v golang.org/x/tools/cmd/goyacc
pkgtools/pkglint: update to 5.6.6 Changes since 5.6.5: - Removed plist-clash since it had crashed unconditionally whenever it was called. This means that in the last 3 years, nobody can have used it in the originally intended way. - Fixed interactions between the --source, --explain, --show-autofix, --autofix and --only options. - Fixed "defined but not used" and "used but not defined" for variables from the pkgsrc infrastructure. - Lots of small fixes and improvements found by the large pkglint code review (12% done).
2018-11-07 21:58:22 +01:00
${RUN} ${PKGSRC_SETENV} ${MAKE_ENV} ${GO} generate ${GO_BUILD_PATTERN}
Updated pkglint to 5.4.3. Changes since 5.4.2: * Variables like ${VAR_${OTHER_VAR}} are no longer checked for use/define mismatch * The check for plural variable names has been removed * The type of variables called *DESTDIR is no longer guessed to be a directory name * The check for unknown shell commands is disabled in Makefile sections that depend on OPSYS * The experimental hand-written shell parser has been replaced with a Yacc-generated one * Meta packages don't need a LICENSE * When PKGNAME is defined in terms of ${DISTNAME:S/from/to/:tl}, more modifiers (like :tl) are handled properly * When the MAINTAINER or OWNER of a package is not the current user, a warning is printed for modified files * The check for share/applications/*.desktop has been disabled, since pkglint would need to inspect the file's actual contents to see whether desktopdb.mk must be included or not * SUBST_CLASSES may also be SUBST_CLASSES.NetBSD * Loosened the usage restrictions for several variables, e.g. many variables that may be appended in a Makefile may also be set unconditionally * PKG_OPTIONS_VAR must be of the form PKG_OPTIONS.*
2016-07-07 14:09:26 +02:00
pkgtools/pkglint: don't access the internet during the build Pkglint needs goyacc, which is provided by devel/go-tools. But that packages pulls in a lot of dependencies that are not needed for pkglint. This includes a Perl interpreter and various cryptography packages. Instead, during build, pkglint installs the only needed tool of that collection (goyacc). Since go-package.mk assumes that each pkgsrc package only downloads and installs a single project, but pkglint now needs two of them (goyacc and pkglint), most parts of go-package.mk had to be copied here and implemented directly.
2018-11-10 12:41:40 +01:00
do-test:
${RUN} ${PKGSRC_SETENV} ${MAKE_ENV} ${GO} test -vet=off -v ${GO_BUILD_PATTERN}
do-install:
pkgtools/pkglint: update to 5.6.9 Changes since 5.6.8: * In addition to the pkglint binary, the whole pkglint code is installed as a library, so that other packages can use the code for doing their own checks on pkgsrc packages, Makefiles, shell programs, or the other file types from pkgsrc. * BUILDLINK_*.* may be used in all files. * Lots of refactorings
2018-12-17 01:15:39 +01:00
${RUN} cd ${WRKDIR} && ${PAX} -rw bin/pkglint ${DESTDIR}${PREFIX}
${RUN} cd ${WRKDIR} && ${PAX} -rw src/netbsd.org/pkglint \
pkg/${GO_PLATFORM}/netbsd.org/pkglint* ${DESTDIR}${PREFIX}/gopkg
Cleaned up and refactored code. The getopt and pkgver code have been extracted to separate packages to make them reusable. Several other functions have been moved to make the structure easier to understand: * dir.go and main.go have been moved to pkglint.go * utility functions from pkglint.go have been moved to mkline.go Now pkglint.go contains only high-level code.
2017-01-01 16:15:47 +01:00
Updated pkglint to 5.4.19. Changes since 5.4.18: * Added generated Go yacc source files to CVS, since starting with Go 1.8 the yacc tool is no longer part of the core distribution. The dependency on yacc would pull in all the Go tools, which are quite a few, and some of these do not currently build since they depend on go-crypto. See https://mail-index.netbsd.org/tech-pkg/2017/03/17/msg017900.html
2017-03-17 23:43:34 +01:00
post-install: do-install-man
Resurrect do-extract target, following atatat's advice. This way, sources are extracted first as any other package, allowing for local patches.
2004-05-09 07:13:24 +02:00
pkgtools/pkglint: fix build go-package.mk needs to be included at the bottom of the package Makefile since it defines several make targets that pkglint also defines.
2018-11-10 12:45:29 +01:00
# This needs to come before bsd.prefs.mk so that SSP_SUPPORTED is properly set.
.include "../../lang/go/go-package.mk"
WRKSRC= ${WRKDIR}/src # Is set unconditionally by go-package.mk
.include "../../mk/bsd.prefs.mk"
Updated pkglint to 5.3.2 Changes since 5.3.1: Alignment of variable values is no longer checked by single line, but by the complete block (e.g. SUBST_*). Pkglint now checks that all variables belonging to a block are indented consistently, so that their values are aligned nicely. Since pkglint does not report warnings, but only notes, and since it can fix them automatically, the burden on the package developers will be very low. Especially, since these notes are only printed when pkglint is called with the -Wspace or -Wall options. Also, pkglint supports running its unit tests now.
2016-01-24 03:03:28 +01:00
do-install-man: .PHONY
Cleaned up and refactored code. The getopt and pkgver code have been extracted to separate packages to make them reusable. Several other functions have been moved to make the structure easier to understand: * dir.go and main.go have been moved to pkglint.go * utility functions from pkglint.go have been moved to mkline.go Now pkglint.go contains only high-level code.
2017-01-01 16:15:47 +01:00
.if ${MANINSTALL:Mcatinstall}
. if ${CATMAN_SECTION_SUFFIX:M[Yy][Ee][Ss]}
pkgtools/pkglint: don't access the internet during the build Pkglint needs goyacc, which is provided by devel/go-tools. But that packages pulls in a lot of dependencies that are not needed for pkglint. This includes a Perl interpreter and various cryptography packages. Instead, during build, pkglint installs the only needed tool of that collection (goyacc). Since go-package.mk assumes that each pkgsrc package only downloads and installs a single project, but pkglint now needs two of them (goyacc and pkglint), most parts of go-package.mk had to be copied here and implemented directly.
2018-11-10 12:41:40 +01:00
${INSTALL_MAN} ${WRKSRC.pkglint}/pkglint.0 ${DESTDIR}${PREFIX}/${PKGMANDIR}/cat1/pkglint.1
Use CATMAN_SECTION_SUFFIX in packages which perform their own catman page installation.
2013-09-12 13:18:40 +02:00
. else
pkgtools/pkglint: don't access the internet during the build Pkglint needs goyacc, which is provided by devel/go-tools. But that packages pulls in a lot of dependencies that are not needed for pkglint. This includes a Perl interpreter and various cryptography packages. Instead, during build, pkglint installs the only needed tool of that collection (goyacc). Since go-package.mk assumes that each pkgsrc package only downloads and installs a single project, but pkglint now needs two of them (goyacc and pkglint), most parts of go-package.mk had to be copied here and implemented directly.
2018-11-10 12:41:40 +01:00
${INSTALL_MAN} ${WRKSRC.pkglint}/pkglint.0 ${DESTDIR}${PREFIX}/${PKGMANDIR}/cat1
Use CATMAN_SECTION_SUFFIX in packages which perform their own catman page installation.
2013-09-12 13:18:40 +02:00
. endif
Honour the setting of MANINSTALL.
2007-09-29 15:39:22 +02:00
.endif
Cleaned up and refactored code. The getopt and pkgver code have been extracted to separate packages to make them reusable. Several other functions have been moved to make the structure easier to understand: * dir.go and main.go have been moved to pkglint.go * utility functions from pkglint.go have been moved to mkline.go Now pkglint.go contains only high-level code.
2017-01-01 16:15:47 +01:00
.if ${MANINSTALL:Mmaninstall}
pkgtools/pkglint: don't access the internet during the build Pkglint needs goyacc, which is provided by devel/go-tools. But that packages pulls in a lot of dependencies that are not needed for pkglint. This includes a Perl interpreter and various cryptography packages. Instead, during build, pkglint installs the only needed tool of that collection (goyacc). Since go-package.mk assumes that each pkgsrc package only downloads and installs a single project, but pkglint now needs two of them (goyacc and pkglint), most parts of go-package.mk had to be copied here and implemented directly.
2018-11-10 12:41:40 +01:00
${INSTALL_MAN} ${WRKSRC.pkglint}/pkglint.1 ${DESTDIR}${PREFIX}/${PKGMANDIR}/man1
Fixed man page handling on platforms that don't have the mandoc macros. Together will all the other changes of the last days, this makes up version 4.16. Most changes affected the elimination of false warnings.
2005-05-23 09:50:40 +02:00
.endif
No substitutions are needed for the pkglint manual page. Re-added a post-install selftest to detect syntax errors in pkglint.pl.
2007-01-06 14:31:26 +01:00
pkgtools/pkglint: update to 5.6.9 Changes since 5.6.8: * In addition to the pkglint binary, the whole pkglint code is installed as a library, so that other packages can use the code for doing their own checks on pkgsrc packages, Makefiles, shell programs, or the other file types from pkgsrc. * BUILDLINK_*.* may be used in all files. * Lots of refactorings
2018-12-17 01:15:39 +01:00
.include "../../devel/go-check/buildlink3.mk"
pkgtools/pkglint: update to 5.7.2 Changes since 5.7.1: * Fixed detection of GNU_CONFIGURE=yes combined with USE_LANGUAGES missing c. This combination tends to fail in the configure phase. * When the distinfo doesn't contain all hashes for the downloaded distfiles (typically SHA512 is missing) and the distfiles are actually downloaded to ${PKGSRCDIR}/distfiles, pkglint can now add the missing hashes. It only does this if there is at least one existing hash and if all existing hashes are correct. * The check for redundant variables has been improved considerably. Before there were several situations in which pkglint didn't get the redundant variable definitions right because its internal model only mimicked reality. The model has been improved and so have the diagnostics. * Pkglint only warns about wrong permissions (for defining or using a variable) when it knows the type of the variable and the permissions for the current file. Before, it had also warned if the permissions for the current file were not explicitly defined. * CFLAGS and LDFLAGS may be appended in buildlink3.mk files. This had been disallowed before, for no apparent reason. There are several places in pkgsrc where especially CFLAGS.${OPSYS} is appended to. * Cleaned up internal handling of relative paths. Previously pkglint sometimes resolved relative paths using the wrong base directory, which led to all kinds of wrong warnings and strange behavior. * Fixed lots of edge cases when parsing Makefile lines. These cases don't occur often but experience tells that the most fundamental code must be as correct as possible (see the handling of relative paths above). * Lots of refactoring and housekeeping, as always.
2019-03-10 20:01:50 +01:00
.include "../../security/go-crypto/buildlink3.mk"
Our portlint has diverged significantly from FreeBSD's, so rename portlint to pkglint, and keep the sources right under files. This makes it much easier to maintain and keep up with changes to out package system.
1998-08-08 00:11:40 +02:00
.include "../../mk/bsd.pkg.mk"
Reference in a new issue Copy permalink